Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase 'group_wait' to let time to inhibition alerts to be executed #1382

Merged
merged 10 commits into from
Sep 25, 2023
Merged

Increase 'group_wait' to let time to inhibition alerts to be executed #1382

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1186bc1
Increase 'group_wait' to let time to inhibition alerts to be executed
Sep 22, 2023
0396c2b
Fix notification-template
Sep 22, 2023
e34882f
Fix notification-template
Sep 22, 2023
244d1af
Add hasPrefix function to rendering template
Sep 22, 2023
0654f7a
Add hasPrefix function to rendering template
Sep 22, 2023
392c6f9
Add hasPrefix function to rendering template
Sep 22, 2023
f86b441
Merge branch 'master' into fix_inhibition_alerts_order_issue
marieroque Sep 22, 2023
d22e9f5
merge master
Sep 22, 2023
73d40ed
Merge branch 'fix_inhibition_alerts_order_issue' of github.com:giants…
Sep 22, 2023
53abbbd
Merge branch 'master' into fix_inhibition_alerts_order_issue
QuentinBisson Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]


### Changed

- Increase `group_wait` from AlertManager config to let more time to inhibition alerts to be executed.

## [4.49.2] - 2023-09-22

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion files/templates/alertmanager/alertmanager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ templates:
route:
group_by: [alertname, cluster_id, installation, status]
group_interval: 15m
group_wait: 30s
group_wait: 1m
repeat_interval: 4h
receiver: root

Expand Down
2 changes: 1 addition & 1 deletion ...ler/resource/alerting/alertmanagerconfig/test/alertmanager-config/case-1-awsconfig.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ templates:
route:
group_by: [alertname, cluster_id, installation, status]
group_interval: 15m
group_wait: 30s
group_wait: 1m
repeat_interval: 4h
receiver: root

Expand Down
2 changes: 1 addition & 1 deletion ...r/resource/alerting/alertmanagerconfig/test/alertmanager-config/case-2-azureconfig.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ templates:
route:
group_by: [alertname, cluster_id, installation, status]
group_interval: 15m
group_wait: 30s
group_wait: 1m
repeat_interval: 4h
receiver: root

Expand Down
2 changes: 1 addition & 1 deletion ...ler/resource/alerting/alertmanagerconfig/test/alertmanager-config/case-3-kvmconfig.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ templates:
route:
group_by: [alertname, cluster_id, installation, status]
group_interval: 15m
group_wait: 30s
group_wait: 1m
repeat_interval: 4h
receiver: root

Expand Down
2 changes: 1 addition & 1 deletion ...resource/alerting/alertmanagerconfig/test/alertmanager-config/case-4-control-plane.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ templates:
route:
group_by: [alertname, cluster_id, installation, status]
group_interval: 15m
group_wait: 30s
group_wait: 1m
repeat_interval: 4h
receiver: root

Expand Down
2 changes: 1 addition & 1 deletion ...e/alerting/alertmanagerconfig/test/alertmanager-config/case-5-cluster-api-v1alpha3.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ templates:
route:
group_by: [alertname, cluster_id, installation, status]
group_interval: 15m
group_wait: 30s
group_wait: 1m
repeat_interval: 4h
receiver: root

Expand Down
2 changes: 1 addition & 1 deletion ...source/alerting/alertmanagerconfig/test/alertmanager-config/case-6-cluster-api-eks.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ templates:
route:
group_by: [alertname, cluster_id, installation, status]
group_interval: 15m
group_wait: 30s
group_wait: 1m
repeat_interval: 4h
receiver: root

Expand Down
Loading