Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase 'group_wait' to let time to inhibition alerts to be executed #1382

Merged
merged 10 commits into from
Sep 25, 2023
Merged

Increase 'group_wait' to let time to inhibition alerts to be executed #1382

merged 10 commits into from
Sep 25, 2023

Conversation

marieroque
Copy link
Contributor

@marieroque marieroque commented Sep 22, 2023 •
edited
Loading

towards https://github.com/giantswarm/giantswarm/issues/28226

Checklist

I have:

  • Described why this change is being introduced
  • Separated out refactoring/reformatting in a dedicated PR
  • Updated changelog in CHANGELOG.md

@marieroque marieroque requested a review from a team as a code owner September 22, 2023 08:58
QuentinBisson
QuentinBisson approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@QuentinBisson QuentinBisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth testing

@marieroque marieroque marked this pull request as draft September 22, 2023 11:38
@marieroque marieroque marked this pull request as ready for review September 22, 2023 14:30
@marieroque
Copy link
Contributor Author

Let's merge it and release pmo on monday...

@QuentinBisson QuentinBisson enabled auto-merge (squash) September 25, 2023 09:50
@QuentinBisson QuentinBisson merged commit 6d13c66 into master Sep 25, 2023
2 checks passed
@QuentinBisson QuentinBisson deleted the fix_inhibition_alerts_order_issue branch September 25, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuantumEnigmaa QuantumEnigmaa QuantumEnigmaa approved these changes

@QuentinBisson QuentinBisson QuentinBisson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marieroque @QuentinBisson @QuantumEnigmaa