Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

legacy-1-15: check for machine deployment subnets when collection reserved subnets #2680

Merged
merged 8 commits into from
Aug 19, 2020
Merged

legacy-1-15: check for machine deployment subnets when collection reserved subnets #2680

merged 8 commits into from
Aug 19, 2020

Conversation

calvix
Copy link
Contributor

@calvix calvix commented Aug 18, 2020 •
edited
Loading

changes:

  • look for AWS cluster and machine deployment subnets when collecting already reserved subnets

in order to work with super legacy branches, I copied necessary files from apiextensions repo to pkg/apis and pkg/clientset (because the API extensions repo is no longer compatible with this operator)

The raw changes are the same as in this PR: #2679

the lookup functions are copied from our current aws-operator

@calvix
Copy link
Contributor Author

calvix commented Aug 18, 2020

ok there is an issue as we still use dep with vendor folder in this branch and i am unabelt o update deps to include apiextensions

#: dep ensure
Solving failure: No versions of github.com/giantswarm/apiextensions met constraints:
	legacy-1-15: Could not introduce github.com/giantswarm/apiextensions@legacy-1-15, as its subpackage github.com/giantswarm/apiextensions/pkg/apis/infrastructure/v1alpha2 is missing. (Package is required by (root).)
	v2.1.0: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v2.0.1: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v2.0.0: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.20: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.19: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.18: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.17: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.16: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.15: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.14: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.13: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.12: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.11: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.10: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.9: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.8: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.7: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.6: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.5: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.4: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.3: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.2: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.1: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.4.0: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.3.11: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.3.10: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.3.9: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.3.8: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.3.7: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.3.6: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.3.5: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.3.4: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.3.3: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.3.2: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.3.1: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.3.0: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.2.6: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.2.5: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.2.4: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.2.3: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.2.2: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.2.1: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.2.0: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.1.2: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.1.1: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	v0.1.0: Could not introduce github.com/giantswarm/[email protected], as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	master: Could not introduce github.com/giantswarm/apiextensions@master, as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	KVMConfig-worker-labels-defaulting: Could not introduce github.com/giantswarm/apiextensions@KVMConfig-worker-labels-defaulting, as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	add-app-pr-deployer-types: Could not introduce github.com/giantswarm/apiextensions@add-app-pr-deployer-types, as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	add-labels: Could not introduce github.com/giantswarm/apiextensions@add-labels, as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	add-load-balancer-type: Could not introduce github.com/giantswarm/apiextensions@add-load-balancer-type, as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	crd-v1: Could not introduce github.com/giantswarm/apiextensions@crd-v1, as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	fix-url: Could not introduce github.com/giantswarm/apiextensions@fix-url, as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	graduate-crds: Could not introduce github.com/giantswarm/apiextensions@graduate-crds, as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	k8s-1-18: Could not introduce github.com/giantswarm/apiextensions@k8s-1-18, as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	links: Could not introduce github.com/giantswarm/apiextensions@links, as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	namespaced_catalog: Could not introduce github.com/giantswarm/apiextensions@namespaced_catalog, as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	test-linting: Could not introduce github.com/giantswarm/apiextensions@test-linting, as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.
	validate-omitempty: Could not introduce github.com/giantswarm/apiextensions@validate-omitempty, as it is not allowed by constraint legacy-1-15 from project github.com/giantswarm/aws-operator.

@calvix
Copy link
Contributor Author

calvix commented Aug 18, 2020

cant believe this actually works :p

@calvix calvix self-assigned this Aug 18, 2020
@calvix calvix requested a review from a team August 19, 2020 13:37
xh3b4sd
xh3b4sd approved these changes Aug 19, 2020
View reviewed changes
pkg/project/project.go
description = "The aws-operator handles Kubernetes clusters running on a Kubernetes cluster inside of AWS."
gitSHA = "n/a"
name string = "aws-operator"
source string = "https://github.com/giantswarm/aws-operator"
version = "5.5.5"
version = "5.5.6-dev"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still need fixing?

@xh3b4sd xh3b4sd mentioned this pull request Aug 19, 2020
Merged
1 task
@calvix calvix merged commit 146214d into legacy-1-15 Aug 19, 2020
@calvix calvix deleted the check-nodepool-clusters-for-reserved-subnets branch August 19, 2020 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xh3b4sd xh3b4sd xh3b4sd approved these changes

Assignees

@calvix calvix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calvix @xh3b4sd