Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

legacy: check for machine deployment subnets when collection reserved subnets #2679

Merged
merged 9 commits into from
Aug 19, 2020

Conversation

calvix
Copy link
Contributor

@calvix calvix commented Aug 18, 2020

Checklist

  • Update changelog in CHANGELOG.md.

towards https://github.com/giantswarm/giantswarm/issues/12450

the functions are copied from our current aws-operator

@calvix calvix changed the title delete all but legacy/v31 controller check for machine deployment subnets when collection reserved subnets Aug 18, 2020
@calvix calvix self-assigned this Aug 18, 2020
@calvix calvix changed the title check for machine deployment subnets when collection reserved subnets legacy: check for machine deployment subnets when collection reserved subnets Aug 18, 2020
@calvix calvix requested a review from a team August 19, 2020 13:37
@xh3b4sd
Copy link
Contributor

xh3b4sd commented Aug 19, 2020

One thing I am not sure about is that the base branch in this PR or the other PR at #2680 is wrong. Both can't just go to legacy and implement the same solution with different code. I am confused.

@calvix
Copy link
Contributor Author

calvix commented Aug 19, 2020

One thing I am not sure about is that the base branch in this PR or the other PR at #2680 is wrong. Both can't just go to legacy and implement the same solution with different code. I am confused.

they don't, one goes to legacy and other to legacy-1-15

@calvix calvix merged commit 5337e8b into legacy Aug 19, 2020
@calvix calvix deleted the legacy-look-for-md-subnets-in-ipam-collector branch August 19, 2020 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants