Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styling): add support for Bootstrap 5 #226

Merged
merged 2 commits into from
Jan 4, 2021
Merged

Conversation

ghiscoding
Copy link
Owner

  • Fix border-radius styling for .headerrow columns
  • Ensure ui-slider maintains correct left margin
  • handle changes to .input-group styling within Bootstrap
  • Handle .input-group inner content height
  • Appropriately size pagination (previous version was cutting off the bottom 6 pixels)
  • Vertically align the pagination icons
  • ref Angular-Slickgrid PR #657

- Fix border-radius styling for `.headerrow` columns
- Ensure ui-slider maintains correct left margin
- handle changes to `.input-group` styling within Bootstrap
- Handle `.input-group` inner content height
- Appropriately size pagination (previous version was cutting off the bottom 6 pixels)
- Vertically align the pagination icons
@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #226 (5d7ca54) into master (bf3610f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #226   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          207       207           
  Lines        11847     11847           
  Branches      4064      4064           
=========================================
  Hits         11847     11847           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf3610f...5d7ca54. Read the comment docs.

@ghiscoding ghiscoding merged commit e35f116 into master Jan 4, 2021
@ghiscoding ghiscoding deleted the feat/bootstrap5 branch January 4, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant