feat(styling): add support for Bootstrap 5

[gcko]

• Fix border-radius styling for .headerrow columns
• Ensure ui-slider maintains correct left margin
• handle changes to .input-group styling within Bootstrap
• Handle .input-group inner content height
• Appropriately size pagination (previous version was cutting off the bottom 6 pixels)
• Vertically align the pagination icons
• Ignore .naverc file (used for managing multiple node versions)

This is done in conjunction with the addition of a demonstration of Bootstrap 5 support in the Angular Bootstrap Demos repository.

[ghiscoding]

Thanks this is great to support BS5... just a quick question, I assume this has no impact on BS3, BS4 implementations... correct?

[gcko]

Thanks this is great to support BS5... just a quick question, I assume this has no impact on BS3, BS4 implementations... correct?

@ghiscoding There is no impact on BS3/BS4, including any changes to existing visual bugs in BS4:

For Example, the following is how the BS4 theme looks:

And in the BS5 theme:

[ghiscoding]

After reviewing your PR a bit further, I got final changes to ask before merging

1. can you move the Flatpickr style changes into the slick-plugins.scss file which holds most of the Flatpickr styling
2. can you also move the Pagination style changes into slick-component.scss which is where all the Pagination styling are

The rest is all good in the bootstrap file.

[gcko]

After reviewing your PR a bit further, I got final changes to ask before merging

1. can you move the Flatpickr style changes into the slick-plugins.scss file which holds most of the Flatpickr styling
2. can you also move the Pagination style changes into slick-component.scss which is where all the Pagination styling are

The rest is all good in the bootstrap file.

@ghiscoding Addressed your comments in 378d25f, please take a look

[ghiscoding]

merge, expect a week or two before a new release since I got a few PRs in the queue.

Thanks a lot for the contribution. ⭐

Do you have a rough idea of when BS5 is to be released?
I'm guessing end of Q1

[gcko]

merge, expect a week or two before a new release since I got a few PRs in the queue.

Thanks a lot for the contribution. ⭐

Do you have a rough idea of when BS5 is to be released?
I'm guessing end of Q1

Thanks for your quick execution on this, it's much appreciated. BS5 is already released (check https://getbootstrap.com/), it currently is Beta-1. I expect that to become a stable release by end of Q1.

[ghiscoding]

This is now fixed and released in the new version 2.25.0, see Release Note.

I also merged your Angular-Slickgrid-Demos PR and bump the Angular-Slickgrid version and used Bootstrap @next until it's released. Thanks a lot for your contribution on this 😉

Cheers ⭐

[gcko]

No worries, happy to participate! Best, Jared M. Scott Founder | Variable. +1-562-302-8063 +886-966463236 From: Ghislain B. <[email protected]> Date: Thursday, January 7, 2021 at 02:11 To: ghiscoding/Angular-Slickgrid <[email protected]> Cc: Jared Scott <[email protected]>, Mention <[email protected]> Subject: Re: [ghiscoding/Angular-Slickgrid] feat(styling): add support for Bootstrap 5 (#657) This is now fixed and released in the new version 2.25.0, see Release Note<https://github.com/ghiscoding/Angular-Slickgrid/releases/tag/v2.25.0>. I also merged your Angular-Slickgrid-Demos PR and bump the Angular-Slickgrid version and used Bootstrap @next until it's released. Thanks a lot for your contribution on this 😉 Cheers ⭐ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#657 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAD7NR2KBCZ2D2NDVD2HGMTSYSRTJANCNFSM4VRSVACA>.