Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): downgrade back to Vite 4.5 to fix HMR issue #1184

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Nov 9, 2023

  • it seems Vite 5 doesn't detect changes when we make changes in the common package and doesn't reload the page when it should, downgrading back to Vite 4.5 fixes the issue
  • also remove paths from tsconfig base since I don't think they are needed neither useful since all packages are linked through tsconfig references -> path
  • this seems to be caused by the upgrade to Rollup 4 in Vite5.0-beta.10, trying any lower version still work correctly

- it seems Vite 5 doesn't detect changes when we make changes in the common package and doesn't reload the page when it should, downgrading back to Vite 4.5 fixes the issue
- also remove paths from tsconfig base since I don't think they are needed neither useful since all packages are linked through tsconfig `references` -> `path`
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #1184 (b8f25d6) into master (eadc5ef) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1184   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          245       245           
  Lines        17270     17268    -2     
  Branches      6241      6242    +1     
=========================================
- Hits         17270     17268    -2     

see 4 files with indirect coverage changes

@ghiscoding ghiscoding merged commit 700f8d5 into master Nov 9, 2023
5 checks passed
@ghiscoding ghiscoding deleted the chore/vite45 branch November 9, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants