Skip to content

Commit

Permalink
chore(deps): downgrade back to Vite 4.5 to fix HMR issue (#1184)
Browse files Browse the repository at this point in the history
- it seems Vite 5 doesn't detect changes when we make changes in the common package and doesn't reload the page when it should, downgrading back to Vite 4.5 fixes the issue
- also remove paths from tsconfig base since I don't think they are needed neither useful since all packages are linked through tsconfig `references` -> `path`
  • Loading branch information
ghiscoding authored Nov 9, 2023
1 parent 7bb9d25 commit 700f8d5
Show file tree
Hide file tree
Showing 4 changed files with 244 additions and 178 deletions.
2 changes: 1 addition & 1 deletion examples/vite-demo-vanilla-bundle/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,6 @@
"@types/whatwg-fetch": "^0.0.33",
"sass": "^1.69.5",
"typescript": "^5.2.2",
"vite": "^5.0.0-beta.16"
"vite": "^4.5.0"
}
}
2 changes: 1 addition & 1 deletion packages/vanilla-force-bundle/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"cross-env": "^7.0.3",
"esbuild": "^0.19.5",
"npm-run-all2": "^6.1.1",
"vite": "^5.0.0-beta.16",
"vite": "^4.5.0",
"yargs": "^17.7.2"
}
}
Loading

0 comments on commit 700f8d5

Please sign in to comment.