Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): replace innerHTML: '×' with textContent: '×' #1156

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Oct 27, 2023

just to reduce the use of innerHTML

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #1156 (cb0297f) into master (47cc546) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          245       245           
  Lines        17075     17075           
  Branches      6151      6151           
=========================================
  Hits         17075     17075           
Files Coverage Δ
...ages/common/src/extensions/extensionCommonUtils.ts 100.00% <ø> (ø)
...ges/common/src/extensions/menuFromCellBaseClass.ts 100.00% <100.00%> (ø)

@ghiscoding ghiscoding merged commit e8b2cfb into master Oct 27, 2023
5 checks passed
@ghiscoding ghiscoding deleted the bugfix/inner-html-close-btn branch October 27, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants