fix(common): replace innerHTML: '×' with textContent: '×' (#…

…1156) Co-authored-by: ghiscoding <[email protected]>
ghiscoding · Oct 27, 2023 · e8b2cfb · e8b2cfb
1 parent 47cc546
commit e8b2cfb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/common/src/extensions/extensionCommonUtils.ts b/packages/common/src/extensions/extensionCommonUtils.ts
@@ -12,7 +12,7 @@ export function addCloseButtomElement(this: SlickColumnPicker | SlickGridMenu, m
   const closePickerButtonElm = createDomElement('button', {
     type: 'button', className: 'close',
     ariaLabel: 'Close',
-    innerHTML: '&times;',
+    textContent: '×',
     dataset: { dismiss: context instanceof SlickColumnPicker ? 'slick-column-picker' : 'slick-grid-menu' }
   });
   menuElm.appendChild(closePickerButtonElm);

diff --git a/packages/common/src/extensions/menuFromCellBaseClass.ts b/packages/common/src/extensions/menuFromCellBaseClass.ts
@@ -155,7 +155,7 @@ export class MenuFromCellBaseClass<M extends CellMenu | ContextMenu> extends Men
       menuElm.style.width = findWidthOrDefault(this.addonOptions?.width);
     }
 
-    const closeButtonElm = createDomElement('button', { ariaLabel: 'Close', className: 'close', type: 'button', innerHTML: '&times;', dataset: { dismiss: this._menuCssPrefix } });
+    const closeButtonElm = createDomElement('button', { ariaLabel: 'Close', className: 'close', type: 'button', textContent: '×', dataset: { dismiss: this._menuCssPrefix } });
 
     // -- Option List section
     if (!(this.addonOptions as CellMenu | ContextMenu).hideOptionSection && isColumnOptionAllowed && optionItems.length > 0) {