(feat): new Major 2.x Release to Support Multiple Grid #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also add new AureliaGridInstance
- to remove confusion with Event Emitters, the 3 Backend Service API methods were renamed to start with the prefix "processOnX" instead of "onX" - for example onFilterChanged is now processOnFilterChanged
- since we had both "hideX" (in SlickGrid) and "showX", it's better to rename them all to "hideX" for consistencies
- to make a distinction between Aurelia Events vs SlickGrid Events, we will use (asg for Aurelia, sg for SlickGrid)
- prior to this, user could predefined searchTerm (singular) or searchTerms (array). To simplify the logic, the singular searchTerm has been dropped in favor of the array searchTerms
- instead of using the generic "params" to pass collection and other arguments, we will use the "editor" object - doing this brings TS types and intellisense
editor.type was enum, but that means the library would be responsible for finding the editor. Also, special logic would have to be in place for custom editors. By making editor.type the exported class function all we have to do is pass it is slickgrid to create
…coding/aurelia-slickgrid into feature/new-major-2-release
- also do the same with Services, make an array and loop through when disposing them
…coding/aurelia-slickgrid into feature/new-major-2-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for a new Major Release
2.xto bring support to Multiple Grid in a View. It brings a lot of breaking changes, a Migration Guide was written