BUG - sorterUtilities circular depency warning #72
Labels
Comments
ghiscoding
added a commit
that referenced
this issue
Jun 1, 2018
|
Fixed in major 2.x branch with commit and cherry-picked to master |
ghiscoding
added a commit
that referenced
this issue
Jun 1, 2018
ghiscoding
added a commit
that referenced
this issue
Jun 5, 2018
* refactor(services): refactor singleton Services into transient - also add new AureliaGridInstance * refactor(service): rename GridExtraService to GridService * deprecate(service): delete GridExtraUtil & move function to GridService * refactor(code): remove deprecated "onBackendEventApi" * refactor(code): remove deprecated "selectOptions" from SelectFilter * refactor(code): remove deprecated FormElementType * refactor(model): remove exportWithFormatter from the GridOptions * refactor(service): remove deprecated initOptions replaced by init * refactor(model): remove deprecated "dataFilters" * refactor(backend): all backend service methods renamed as processOnX - to remove confusion with Event Emitters, the 3 Backend Service API methods were renamed to start with the prefix "processOnX" instead of "onX" - for example onFilterChanged is now processOnFilterChanged * refactor(gridOptions): all Grid Menu showX were renamed hideX - since we had both "hideX" (in SlickGrid) and "showX", it's better to rename them all to "hideX" for consistencies * refactor(events): change aurelia event prefix - to make a distinction between Aurelia Events vs SlickGrid Events, we will use (asg for Aurelia, sg for SlickGrid) * refactor(i18n): add i18n Grid Options instead of using params * refactor(grid): add multiple grids in a view * refactor(searchTerm): remove searchTerm and only use searchTerms - prior to this, user could predefined searchTerm (singular) or searchTerms (array). To simplify the logic, the singular searchTerm has been dropped in favor of the array searchTerms * refactor(example): fix multiple grids not displayed * refactor(styling): change highlight and selected row color to blueish * refactor(styling): make selected row a little darker * refactor(formatter): console error should contain new grid options i18n * update readme * refactor(services): add singleton(true) decorator for multiple grids * fix(i18n): make sure all Services use correct Grid Options i18n * refactor(example): make row selection titles more obvious * refactor(event): renamed onGridStateServiceChanged to onGridStateChanged * feat(grid): expose Slick Grid & DataView objects in AureliaGridInstance * fix(grid): Dynamically Add Column Header was broken with non-singleton * refactor(styling): change mouse hover & selection background colors * refactor(example): add 2x grids in the Basic Grid sample * refactor(editor): move all Editor params into editor - instead of using the generic "params" to pass collection and other arguments, we will use the "editor" object - doing this brings TS types and intellisense * refactor(service): refactored delete/update item functions * fix(sorter): issue #72 circular dependency from last PR #70 * fix(event): remove e.stopImmediatePropagation to fix issue #60 * refactor(columnDef): make editor.type the Editor class export function editor.type was enum, but that means the library would be responsible for finding the editor. Also, special logic would have to be in place for custom editors. By making editor.type the exported class function all we have to do is pass it is slickgrid to create * refactor(example): fixed onCellChange event and advertise delete feature * refactor(event): expose event to columnDef onCellClick and onCellChange * refactor(event): use subscriptions array and loop to unsubscribe - also do the same with Services, make an array and loop through when disposing them * refactor(editor): change ColumnEditor.type to ColumnEditor.model * refactor(filter): use Filter model on ColumnFilter, remove FilterType * feat(gridState): Grid State & Presets for columns (position, size, visibility) (#74)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm submitting a bug report
Current behavior:
while implementing PR #70 in my Angular-Slickgrid repo, I noticed that Angular throws me some circular dependency warnings
that is because sorterUtilities.ts import Sorters, then each Sorter import sorterUtilities and so... we are in a circular dependency injection. I had to get this new compareDates() function into it's own file.
Expected/desired behavior:
no warnings
The text was updated successfully, but these errors were encountered: