Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: migrate to Slickgrid-Universal v4.0 and Aurelia 2, fixes #709 #1124

Merged
merged 7 commits into from
Dec 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added .env.development
Empty file.
164 changes: 0 additions & 164 deletions .eslintrc

This file was deleted.

61 changes: 61 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
{
"root": true,
"parser": "@typescript-eslint/parser",
"parserOptions": {
"sourceType": "module"
},
"env": {
"browser": true,
"node": true
},
"settings": {
"node": {
"tryExtensions": [".js", ".json", ".node", ".ts", ".d.ts"],
"resolvePaths": ["node_modules/@types"]
}
},
"extends": [
"plugin:@typescript-eslint/eslint-recommended",
"plugin:@typescript-eslint/recommended"
],
"plugins": ["@typescript-eslint", "node"],
"ignorePatterns": ["*.spec.ts"],
"rules": {
"class-methods-use-this": "off",
"consistent-return": "off",
"curly": ["error", "all"],
"default-param-last": "off",
"dot-notation": "off",
"import/extensions": "off",
"import/no-extraneous-dependencies": "off",
"import/no-unresolved": "off",
"import/order": "off",
"node/no-missing-require": "off",
"no-param-reassign": "off",
"no-restricted-syntax": "off",
"no-underscore-dangle": "off",
"no-use-before-define": [
"error",
{
"functions": false,
"classes": false
}
],
"node/no-extraneous-require": "off",
"node/no-unpublished-require": "off",
"node/no-unsupported-features/es-syntax": "off",
"prefer-destructuring": "off",
"prefer-object-spread": "off",
"strict": "off",
"max-len": "off",
"arrow-body-style": "off",
"@typescript-eslint/ban-ts-comment": "off",
"@typescript-eslint/no-empty-function": "off",
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-non-null-assertion": "off",
"@typescript-eslint/no-unused-vars": [
"error",
{ "argsIgnorePattern": "^_", "destructuredArrayIgnorePattern": "^_" }
]
}
}
66 changes: 66 additions & 0 deletions .github/workflows/publish-dry-run.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
name: 🏷️👀 Publish (dry-run)

on: workflow_dispatch

permissions:
contents: write
id-token: write

jobs:
deploy-npm-latest:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Retrieve current Date Time in EST
shell: bash
run: echo "START_TIME=$(TZ=":America/New_York" date -R|sed 's/.....$//')" >> $GITHUB_ENV

- name: Current datetime - ${{ env.START_TIME }}
run: echo ${{ env.START_TIME }}

- name: Clone repository
uses: actions/checkout@v4
with:
fetch-depth: 0
token: ${{ secrets.GITHUB_TOKEN }}

- if: ${{ github.event.pull_request.merged != true && contains('["ghiscoding"]', github.actor) != true }}
name: Ensure current actor is allowed to run the workflow
run: |
echo "Error: Your GitHub username (${{ github.actor }}) is not on the allowed list of admins for this workflow"
exit 1

- name: Set NodeJS
uses: actions/setup-node@v4
with:
registry-url: 'https://registry.npmjs.org/'
node-version: 20

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT

- uses: actions/cache@v3
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-

- name: Run yarn install dependencies
run: yarn --frozen-lockfile

- name: Run Project Build
run: yarn run build

- name: "[dry-run] 🧪 NPM Release"
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_CONFIG_PROVENANCE: true
run: |
git config --global user.name "${{ github.actor }}"
git config --global user.email "${{ github.actor }}@users.noreply.github.com"
npm whoami
npx release-it --ci --dry-run
4 changes: 2 additions & 2 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"--runInBand",
"${fileBasename}",
"--config",
"${workspaceFolder}/test/jest.config.js"
"${workspaceFolder}/test/jest.config.ts"
],
"console": "internalConsole",
"internalConsoleOptions": "neverOpen",
Expand All @@ -53,7 +53,7 @@
"--runInBand",
"${fileBasename}",
"--config",
"${workspaceFolder}/test/jest.config.js",
"${workspaceFolder}/test/jest.config.ts",
"-t=${selectedText}$",
"--watch"
],
Expand Down
4 changes: 2 additions & 2 deletions .vscode/tasks.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{
"label": "Build Library",
"type": "shell",
"command": "yarn run build",
"command": "yarn run build:plugin",
"problemMatcher": []
},
{
Expand Down Expand Up @@ -40,7 +40,7 @@
{
"label": "Start Library Development",
"type": "shell",
"command": "yarn start:dev",
"command": "yarn start",
"problemMatcher": []
},
{
Expand Down
Loading