Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: migrate to Slickgrid-Universal v4.0 and Aurelia 2, fixes #709 #1124

Merged
merged 7 commits into from
Dec 15, 2023

Conversation

ghiscoding
Copy link
Owner

⚠️ requires Slickgrid-Universal v4.0 and Aurelia 2

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 68 lines in your changes are missing coverage. Please review.

Comparison is base (827f90c) 99.90% compared to head (ec02764) 22.74%.
Report is 6 commits behind head on master.

Files Patch % Lines
...lia-slickgrid/custom-elements/aurelia-slickgrid.ts 0.00% 68 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1124       +/-   ##
===========================================
- Coverage   99.90%   22.74%   -77.16%     
===========================================
  Files           9        8        -1     
  Lines         933      893       -40     
  Branches      338      313       -25     
===========================================
- Hits          932      203      -729     
- Misses          1      690      +689     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding changed the title feat!: migrate to Slickgrid-Universal v4.0 new major version feat!: migrate to Slickgrid-Universal v4.0 new major version, fixes #709 Dec 12, 2023
@ghiscoding ghiscoding changed the title feat!: migrate to Slickgrid-Universal v4.0 new major version, fixes #709 BREAKING CHANGE: migrate to Slickgrid-Universal v4.0 new major version, fixes #709 Dec 12, 2023
@ghiscoding ghiscoding changed the base branch from next to master December 15, 2023 00:38
@ghiscoding ghiscoding changed the title BREAKING CHANGE: migrate to Slickgrid-Universal v4.0 new major version, fixes #709 BREAKING CHANGE: migrate to Slickgrid-Universal v4.0 and Aurelia 2, fixes #709 Dec 15, 2023
@ghiscoding ghiscoding merged commit 8d0aa70 into master Dec 15, 2023
4 of 6 checks passed
@ghiscoding ghiscoding deleted the feat/universal4 branch December 15, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants