-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IQ1_S: attempt to fix SYCL #6014
Conversation
Thanks for looking into this Assigning the Intel team for review. AFAICT they are currently focused on resolving some additional problems with the SYCL backend (#6006) and might take them some time to review this, and I don't want to interfere in their work with more PRs (as long as the CI on |
@ikawrakow @ggerganov The code of IQ1_S are fixed by several PRs with different solution. It will make this part be complex and easy be with error.
PS: PR (#6006) is cancelled due to I see another PR has fixed the SYCL backend build issue. |
So, I'm not sure what those PR's that fix No, I don't have a local environment to test the SYCL implementation. But the CI is definitely not failing because of this PR. |
@ikawrakow We will review this shortly as we close some major fixes. Thanks for your contribution. |
@ikawrakow Thank your support! |
@ggerganov I see you have a WIP to do this, but as far as I can tell this is for the previous
IQ1_S
version, so decided to try to fix it myself.