feat(wgsl): add first and either sampling for @interpolate(flat, …)
#6181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
force-pushed
the
first-or-either-sampling-for-flat-interp
branch
from
c8831c5
to
6c1ef9f
Compare
ErichDonGubler
changed the title
first and either sampling typesfirst and either sampling types for flat interpolation
ErichDonGubler
changed the title
first and either sampling types for flat interpolationfirst and either sampling types for flat interpolation
ErichDonGubler
changed the title
first and either sampling types for flat interpolationfirst and either sampling types for @interpolate(flat, …)
ErichDonGubler
force-pushed
the
first-or-either-sampling-for-flat-interp
branch
2 times, most recently
from
eb2521a
to
ec3f47c
Compare
teoxoy
reviewed
Aug 30, 2024
ErichDonGubler
commented
Aug 30, 2024
ErichDonGubler
force-pushed
the
first-or-either-sampling-for-flat-interp
branch
from
ec3f47c
to
0591c9a
Compare
ErichDonGubler
commented
Aug 30, 2024
ErichDonGubler
changed the title
first and either sampling types for @interpolate(flat, …)first and either sampling for @interpolate(flat, …)
ErichDonGubler
force-pushed
the
first-or-either-sampling-for-flat-interp
branch
from
0591c9a
to
5c69262
Compare
teoxoy
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Resolves #6122.
Description
Context is in the linked issue.
Testing
Added some coverage for both (1) new valid parses as snapshot testing and (2) invalid parses as validation testing.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.