Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support first and either sampling in @interpolate(flat, …) #6122

Closed
2 tasks
ErichDonGubler opened this issue Aug 16, 2024 · 1 comment · Fixed by #6181
Closed
2 tasks

Support first and either sampling in @interpolate(flat, …) #6122

ErichDonGubler opened this issue Aug 16, 2024 · 1 comment · Fixed by #6181
Assignees
@ErichDonGubler
Labels
area: validation Issues related to validation, diagnostics, and error handling lang: WGSL WebGPU Shading Language naga Shader Translator

Comments

@ErichDonGubler
Copy link
Member

ErichDonGubler commented Aug 16, 2024 •
edited
Loading

The WebGPU spec. made some changes to WGSL with gpuweb#4639 that we need to handle; it…

  • …added the first and either interpolation sampling to the flat interpolation type, with first as the default.
  • …added validation that perspective and linear interpolation types are constrained to the set of {center,centroid,sample}, to exclude the new interpolation sampling options.
@ErichDonGubler ErichDonGubler added area: validation Issues related to validation, diagnostics, and error handling naga Shader Translator lang: WGSL WebGPU Shading Language labels Aug 16, 2024
@ErichDonGubler ErichDonGubler changed the title Support first and either interpolation sampling [meta] Support first and either interpolation sampling Aug 16, 2024
@ErichDonGubler ErichDonGubler changed the title [meta] Support first and either interpolation sampling Support first and either interpolation sampling Aug 16, 2024
@jimblandy
Copy link
Member

It seems that the CTS was updated to cover this, causing quite a few "regressions" in Firefox.

@ErichDonGubler ErichDonGubler changed the title Support first and either interpolation sampling Support first and either interpolation sampling in @interpolate(flat, …) Aug 26, 2024
@ErichDonGubler ErichDonGubler self-assigned this Aug 26, 2024
@ErichDonGubler ErichDonGubler moved this from Todo to In Progress in WebGPU for Firefox Aug 28, 2024
@ErichDonGubler ErichDonGubler mentioned this issue Aug 29, 2024
Merged
6 tasks
@ErichDonGubler ErichDonGubler changed the title Support first and either interpolation sampling in @interpolate(flat, …) Support first and either sampling in @interpolate(flat, …) Aug 30, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in WebGPU for Firefox Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ErichDonGubler ErichDonGubler

Labels
area: validation Issues related to validation, diagnostics, and error handling lang: WGSL WebGPU Shading Language naga Shader Translator
Projects
WebGPU for Firefox
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(wgsl): add first and either sampling for @interpolate(flat, …) erichdongubler-mozilla/wgpu
2 participants
@ErichDonGubler @jimblandy