-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use workspace dependencies more. #6020
Use workspace dependencies more. #6020
Conversation
This could be a draft and get updated as more dependencies are switched over, or we could use this to be sure that there aren't issues from enabling this. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I'm going to merge this in a few hours, unless somebody has an objection (CC @gfx-rs/wgpu); I think the potential for conflicts is high, and I haven't felt or seen any controversy that what's here already is fine by itself. |
Head branch was pushed to by a user without write access
05c420f
to
0c04ced
Compare
I've rebased this forward, added in the further work that I'd done. |
0c04ced
to
b5d7d94
Compare
Should this close #3407? I think so. I don't think we want all the deps in the workspace toml, only the ones present in more than one crate. |
To me it seems like tracking all versions in one coherent place is nice. That way you also don't have to be aware of this and go move dependencies back and forth when they start being used in >1 place, or have their use removed and end up remaining used by just one crate. |
That's fair, let's keep it open for the time being then. |
b5d7d94
to
00a290c
Compare
Just waiting on @gfx-rs/naga's approval here. |
Description
In the past, workspace dependencies couldn't be used everywhere due to complications in the Firefox environment. These are believed to be resolved and so we can try using them again to reduce version management overhead and duplicated information.
This patch makes some dependencies into workspace dependencies.
The
bitflags
dependency is changed to version2.6
to match what was in naga rather than the bare2
used elsewhere.Testing
Compilation.
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.Add change toEDIT by @ErichDonGubler: Not necessary. 🙂CHANGELOG.md
. See simple instructions inside file.