[wgpu-hal] gles/wgl: Migrate from ancient/unmaintained winapi to windows-rs
#6006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
gles-wgl-windows-rs
branch
from
7437069
to
04d45c0
Compare
Wumpf
approved these changes
Jul 22, 2024
MarijnS95
force-pushed
the
gles-wgl-windows-rs
branch
from
04d45c0
to
264f81c
Compare
Wumpf
reviewed
Jul 22, 2024
|
I suspect this windows version dance is going to be a recurring theme in our future. That is one upside off using a years-abandoned crate, nothing ever changes 😛 Anywho I think we (the maintainers) should figure out what the viable paths forward are that satisfy mozilla-central and wgpu's external users and then clearly communicate that, as I don't want Marijn to do duplicate work and I don't want this to explode mozilla-central.
|
MarijnS95
requested review from
cwfitzgerald,
glandium,
ErichDonGubler and
waywardmonkeys
6 tasks
glandium
approved these changes
Jul 23, 2024
|
@cwfitzgerald since we've made the resolution to just go ahead and use |
MarijnS95
changed the title
winapi to windows-rswinapi to windows-rs
cwfitzgerald
approved these changes
Jul 24, 2024
|
Ready to land, just needs merge conflicts resolved |
MarijnS95
force-pushed
the
gles-wgl-windows-rs
branch
from
264f81c
to
3c8785b
Compare
MarijnS95
force-pushed
the
gles-wgl-windows-rs
branch
from
3c8785b
to
e3a7c6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Contributes to #3207
Same as PR #5956 but for GLES/WGL, instead of the Dx12 backend.
Description
Replaces ancient, deprecated, unmaintained
winapicrate withwindows-rs. The full justification is in the linked issue and PR above.Testing
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.