Fix Panic in Surface Configure (#4635) (0.18 backport) #4649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almost, you targeted the wrong branch in the github ui - this PR shouldn't go to |
|
(fixed that for you, just waiting for CI now) |
Wumpf
approved these changes
Nov 11, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Am I doing this right
#4635 has a "PR: Needs back-porting" tag
This is #4635 grafted (hg graft, not git cherry-pick, may not work the same way, I don't know, github marks the commit as "unverified" which makes sense because it's not really by @cwfitzgerald) onto the 0.18 branch
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Testing
I tested it with the code that was crashing in #4630 and it did not crash