Update CI to install wasm-pack from binary #3754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes CI failure due to a library used by wasm-pack not being compatible with our MSRV
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CI failure due to a library used by wasm-pack not being compatible with our MSRV
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Seemed unnecessary since I doubt anyone looking at our changelog cares about changes to our CI. Just lmk if I should add something though.
Connections
Fixes this CI failure https://github.com/gfx-rs/wgpu/actions/runs/4889931906/jobs/8758745206?pr=3750#step:3:221
Description
Updates the wasm-test CI job to install wasm-pack from a precompiled binary using taiki-e/install-action.
Now that wasm-pack has released a version with support for workspace inheritance we don't need to build it ourselves.
This has the benefit of avoiding a CI failure that started today due to our MSRV no longer being compatible with wasm-pack's time dependency. This failure is what prompted this PR.
Testing
Probably easiest to just run the CI on Github.
If you want to run it locally, I used https://github.com/nektos/act with this command to mimic a github action runner using a minimal image that still contained the Rust stuff needed to get past the wasm-pack install.