Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish examples to wgpu.rs on updates to trunk branch instead of gecko #3750

Merged
merged 4 commits into from
May 11, 2023

Conversation

paul-hansen
Copy link
Contributor

@paul-hansen paul-hansen commented May 5, 2023

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
Fixes #3684

Description
Switched the branch the publish action is using to trunk to allow the examples to be kept up to date as requested in #3684

When testing I ran into the error rustup: command not found in the Main Install Rust WASM target step, I fixed this by using dtolnay/rust-toolchain which is what the Bevy CI template uses for installing Rust in an action. Lmk if you would prefer I revert that.

Testing
I tested this by installing https://github.com/nektos/act and running this command to mimic a github action runner using a minimal image that still contained the Rust stuff needed.

act -P ubuntu-latest=ghcr.io/catthehacker/ubuntu:rust-latest -j publish

Note that it fails at uploading to github pages, which is expected since running locally you wouldn't have access to the secrets needed to do so.

@paul-hansen
Copy link
Contributor Author

CI failure is not related to this PR. The time crate updated since our last CI run and raised it's MSRV to 1.65 which broke the version of wasm-pack we are using since we compile for 1.64.

@paul-hansen
Copy link
Contributor Author

Opened a different PR that should fix the CI issue: #3754

@paul-hansen
Copy link
Contributor Author

Rebased on the latest trunk to get the CI fix

@paul-hansen
Copy link
Contributor Author

Looks like running the publish job locally is failing due to the updated time dependency too. Working on a fix.

@cwfitzgerald
Copy link
Member

We can absolutely run the publishing job on latest stable. Only normal CI needs to check our MSRV

Turns out this wasn't needed to test locally,
just needed to use a runner image with rust installed.
@paul-hansen
Copy link
Contributor Author

paul-hansen commented May 7, 2023

Ah cool, I was thinking of using taiki-e/install-action to install cargo-binstall and use that to install wasm-bindgen-cli. But I was getting a bunch of too many requests errors using binstall so changing it to not use the msrv might be simpler.

Fixes issue with building wasm-bindgen-cli.
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@cwfitzgerald cwfitzgerald merged commit 28374fb into gfx-rs:trunk May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI Publishing Jobs for WebGPU Release
2 participants