-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URLs are not autolinked in GFM mode #306
Comments
Thanks for pointing this out but without the inside knowledge of what GFM actually supports I can't properly implement this. |
Did a little digging, and it looks like the autolink filter in HTML pipeline, uses Rinku, a Ruby gem which implements autolinking. It'd be an additional dependency, so its your call, but maybe make it an optional dependency that autolinks if present? |
I would accept a pull request with Rinku being an optional dependency for kramdown. However, it should then be mentioned in kramdown's GFM docs that Rinku has to be installed for the GFM parser to work correctly. |
Closed because feature request issues are now tracked through a dedicated project - see https://github.com/gettalong/kramdown/projects/1 |
I attempted to fix this in #528. Hopefully someone can finish it off or work on a better fix. |
@cup See my comment above |
If someone is actively working on a fix, we can re-open. All open pull requests/issues that need actions from contributers are tracked through the dedicated project. |
The reason for having the project is to collect all issues needing work done by contributors. Once somebody works on such an issue I'm glad to reopen it. But until then these issues just clobber the issue tracker. As for the issue at hand: As indicated by the label, pull requests for resolving this feature requests are welcome! |
For anyone using GitHub Pages, you can simply add this to
you dont even have to declare the plugin in http://github.com/github/pages-gem/blob/fb5c3f2/lib/github-pages/plugins.rb#L9 reference: |
@benbalter The GFM parser has been extracted from the main kramdown distribution. If this issue should be resolved, please create a ticket at https://github.com/kramdown/parser-gfm/issues since I can't transfer this issue there. Thank you! |
Per https://help.github.com/articles/autolinked-references-and-urls/#urls, in GFM, URLs should automatically become links, even when not wrapped in
<
and>
.Steps to reproduce
Link http://example.com
Expected
`Link http://example.com>
Actual
Link http://example.com
The text was updated successfully, but these errors were encountered: