-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GFM autolinking doesn't work #490
Comments
Hmm... I don't really know what you want... kramdown's syntax is clearly defined by its syntax document. Redcarpet has a different syntax, so what? Each Markdown converter differs in some ways from most of the others. None is clearly better than the other (otherwise we would have a real Markdown standard). If you like how redcarpet converts Markdown, please use Redcarpet. If you like how kramdown does its job, please use kramdown. But it is just a decision you have to make. Aside from this, take a look at the original Markdown spec by Gruber where you will find the reason why kramdown implements these autolinks. Could you clarify what you want? And note that changes to kramdown's syntax have a very high chance of only being implemented in a new major version. Changes to kramdown's GFM parser are implemented if the current implementation doesn't match the GFM one and are considered bugs. |
Current implementation of GFM parser in kramdown doesn't match GFM - https://help.github.com/articles/autolinked-references-and-urls/#urls kramdown GFM doesn't link URLs in pages that are linked by GitHub in source GFM. See https://kubernetes.io/docs/reference/generated/kubectl/kubectl/ for example. |
Okay, then this has already been requested in #306 but there has not been a pull request for this. Since #306 is already tracked in the Feature Requests Project, I will close this issue. |
Ok. So #306 is not actually closed.. https://github.com/gettalong/kramdown/projects/1 |
It is closed because it is waiting for a pull request, as stated on the feature requests project page. |
That is strange. Usually issues are closed when they are resolved. This one is not resolved. |
These issues are feature requests that need a pull request. So they are resolved from my point of view. And are therefore assigned to the feature requests project. |
Fixing GFM rendering to match official GFM speccy is a feature request? |
Yes, in case of the GFM parser it is since there is now, since only a short time, an official spec and implementation which the one in kramdown will never match (and was never designed to because when it was started there was no GFM spec) unless there are contributions. |
kramdown autolinking feature is strange. The better name for it is
semiautolinks
, because you still need to decorate every URL manually. This is different from Redcarpet:autolink
extension and GFM autolinking https://help.github.com/articles/autolinked-references-and-urls/The text was updated successfully, but these errors were encountered: