Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗣️ Add Team Drilldown in Looker #157

Closed
7 of 8 tasks
Tracked by #110
hubertdeng123 opened this issue Jul 7, 2023 · 4 comments
Closed
7 of 8 tasks
Tracked by #110

🗣️ Add Team Drilldown in Looker #157

hubertdeng123 opened this issue Jul 7, 2023 · 4 comments

Comments

@hubertdeng123
Copy link
Member

hubertdeng123 commented Jul 7, 2023

Teams that are really good at engaging with users will be more successful because feedback is priceless. It is the raw material for our product vision. If we don’t engage, feedback dries up, and we build a product our customers don’t find useful.
Screenshot 2023-07-21 at 2 32 21 PM

We’ve been reaching 95% issue SLO response time for Support - great! We’ve been at like 80-85% for POs - good! How do we get POs to great? We don’t have good enough data to generate and validate hypotheses. So we want to improve our visibility. We want teams to have a clear idea of the product areas they own, and we want to filter down our GitHub response metrics to track the performance of individual teams. This will help surface data in order to find learning opportunities on what we’re doing well and what we can do better.

More Code as a Source of Truth

Last quarter we started using the product-owners.yml in security-as-code as a source of truth for defining product owners for product areas. However, it’s not well defined how these product areas map to internal teams.

Each product area will no longer be mapped to product owners, but a team. One team can own multiple product areas. This will clear up any ambiguity on the relationship between product areas and teams. If a product area grows to span multiple teams, it will be broken down into multiple product areas.

Teams will now be defined in security-as-code and will map to a list of product owners and the slack channel to send notifications to. Sentry repos will also be defined in security-as-code to map to product areas. This enables us to develop visibility into the teams and product areas that are associated with each repo.

Example snippet of future product-owners.yml

by_team:
  team-issues:
    product_owners: # populates GitHub teams
      - eran.arkin
      - rachel.wang
      - zpropersi
      - brian.thi
      - scefali
    slack_channel: foo 
  team-dnd:
    product_owners:
      - adam.mckerlie
      - brent.charbonneau
    slack_channel: bar 

by_area:
  "Sign In":
    - "team-enterprise"
  "Issues":
    - "team-issues"

by_repo:
  sentry-javascript: "team-web-sdks"
  relay: "team-ingest"
  self-hosted: "team-ospo"
  sentry-native: "team-processing"

Dashboard Changes

We’ll need to overhaul the 401 dashboard. It will require us to enable filtering the issue response by issues owned by a team instead of all issues. This will allow teams to have a more fine tuned dashboard to track how well they’re doing on issue response, and issues that are slipping through the cracks.

Weekly Looker scores to publish a team’s response performance to slack will allow teams to keep track of how well they’re doing, and if there’s work to be done to improve.

Tasks

Preview Give feedback
  1. 4 of 4
  2. 2 of 2
  3. 4 of 4
  4. 2 of 5
  5. 2 of 2

Future work

  • giving incentives for good GH response times
This was referenced Jul 12, 2023
@hubertdeng123 hubertdeng123 changed the title All Issues Belong on a Project Board No issues left behind (all issues belong on a project board) Jul 13, 2023
@chadwhitacre chadwhitacre changed the title No issues left behind (all issues belong on a project board) Team visibility on 401 Jul 21, 2023
@chadwhitacre chadwhitacre changed the title Team visibility on 401 Add Team Drilldown in Looker Jul 24, 2023
@chadwhitacre chadwhitacre changed the title Add Team Drilldown in Looker 🗣️ Add Team Drilldown in Looker Jul 24, 2023
azaslavsky added a commit to getsentry/sentry that referenced this issue Jul 29, 2023
This comparator had a (granted, unlikely in practice) bug where it would
crash if only one of the two models had the field in question set. The
new setup tests for field existence before attempting the comparison
logic, and always returns a list of comparators (empty on success,
filled with findings on failure) rather than using the more confusing
union type like before.

Issue: getsentry/team-ospo#157
azaslavsky added a commit to getsentry/sentry that referenced this issue Jul 29, 2023
This comparator is added to prevent sensitive data like user emails from
leaking into logs, stack traces, and so on.

Issue: getsentry/team-ospo#157
azaslavsky added a commit to getsentry/sentry that referenced this issue Jul 29, 2023
This comparator prevents sensitive user data like password hashes,
secret keys, and refresh tokens from leaking into logs and stack traces.

Issue: getsentry/team-ospo#157
azaslavsky added a commit to getsentry/sentry that referenced this issue Jul 31, 2023
This comparator had a (granted, unlikely in practice) bug where it would
crash if only one of the two models had the field in question set. The
new setup tests for field existence before attempting the comparison
logic, and always returns a list of comparators (empty on success,
filled with findings on failure) rather than using the more confusing
union type like before.

Issue: getsentry/team-ospo#157
azaslavsky added a commit to getsentry/sentry that referenced this issue Jul 31, 2023
This comparator had a (granted, unlikely in practice) bug where it would
crash if only one of the two models had the field in question set. The
new setup tests for field existence before attempting the comparison
logic, and always returns a list of comparators (empty on success,
filled with findings on failure) rather than using the more confusing
union type like before.

Issue: getsentry/team-ospo#157
azaslavsky added a commit to getsentry/sentry that referenced this issue Jul 31, 2023
This comparator is added to prevent sensitive data like user emails from
leaking into logs, stack traces, and so on.

Issue: getsentry/team-ospo#157
azaslavsky added a commit to getsentry/sentry that referenced this issue Jul 31, 2023
This comparator prevents sensitive user data like password hashes,
secret keys, and refresh tokens from leaking into logs and stack traces.

Issue: getsentry/team-ospo#157
azaslavsky added a commit to getsentry/sentry that referenced this issue Jul 31, 2023
This comparator prevents sensitive user data like password hashes,
secret keys, and refresh tokens from leaking into logs and stack traces.

Issue: getsentry/team-ospo#157
@hubertdeng123
Copy link
Member Author

Investigated moving slack team scores to eng-pipes, think I should be able to query data from bigquery to get slack weekly scores into eng-pipes. Testing this locally doesn't seem to be an easy task though.

@chadwhitacre
Copy link
Member

Notifications are working! 💃

Screenshot 2023-10-16 at 4 39 04 PM

@chadwhitacre
Copy link
Member

Weekly reports are also working! 💃

Screenshot 2023-10-23 at 5 27 22 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants