-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backup): Add EmailObfuscatingComparator #53763
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Automatically applied to PRs that change backend components
label
Jul 28, 2023
azaslavsky
force-pushed
the
azaslavsky/backup/improve_date_updated
branch
from
July 28, 2023 02:48
c1e2579
to
855bc17
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/email_obfuscator
branch
from
July 28, 2023 02:48
987ca42
to
1a19d36
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/improve_date_updated
branch
from
July 28, 2023 17:35
855bc17
to
cbdff26
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/email_obfuscator
branch
from
July 28, 2023 17:35
1a19d36
to
40a19fe
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/email_obfuscator
branch
from
July 28, 2023 17:42
40a19fe
to
20edd8c
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/improve_date_updated
branch
from
July 28, 2023 21:46
cbdff26
to
5c84714
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/email_obfuscator
branch
from
July 28, 2023 21:46
20edd8c
to
782f35a
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/improve_date_updated
branch
from
July 28, 2023 23:21
5c84714
to
3a4509d
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/email_obfuscator
branch
from
July 28, 2023 23:28
782f35a
to
58ae734
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/improve_date_updated
branch
from
July 29, 2023 00:10
3a4509d
to
e0f1dcd
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/email_obfuscator
branch
from
July 29, 2023 00:11
58ae734
to
eb5a5b8
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/improve_date_updated
branch
from
July 29, 2023 01:22
e0f1dcd
to
d6bed94
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/email_obfuscator
branch
from
July 29, 2023 01:22
eb5a5b8
to
df68abd
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/improve_date_updated
branch
from
July 31, 2023 14:30
d6bed94
to
295a3bc
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/email_obfuscator
branch
from
July 31, 2023 14:30
df68abd
to
c3574da
Compare
Base automatically changed from
azaslavsky/backup/improve_date_updated
to
master
July 31, 2023 15:01
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #53763 +/- ##
==========================================
+ Coverage 77.74% 79.52% +1.78%
==========================================
Files 4969 4964 -5
Lines 209957 209725 -232
Branches 35753 35709 -44
==========================================
+ Hits 163227 166790 +3563
+ Misses 41595 37814 -3781
+ Partials 5135 5121 -14 |
hubertdeng123
approved these changes
Jul 31, 2023
This comparator is added to prevent sensitive data like user emails from leaking into logs, stack traces, and so on. Issue: getsentry/team-ospo#157
azaslavsky
force-pushed
the
azaslavsky/backup/email_obfuscator
branch
from
July 31, 2023 22:06
c3574da
to
2006393
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comparator is added to prevent sensitive data like user emails from leaking into logs, stack traces, and so on.
Issue: getsentry/team-ospo#157