Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backup): Add EmailObfuscatingComparator #53763

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

azaslavsky
Copy link
Contributor

This comparator is added to prevent sensitive data like user emails from leaking into logs, stack traces, and so on.

Issue: getsentry/team-ospo#157

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 28, 2023
@azaslavsky azaslavsky force-pushed the azaslavsky/backup/improve_date_updated branch from c1e2579 to 855bc17 Compare July 28, 2023 02:48
@azaslavsky azaslavsky force-pushed the azaslavsky/backup/email_obfuscator branch from 987ca42 to 1a19d36 Compare July 28, 2023 02:48
@azaslavsky azaslavsky force-pushed the azaslavsky/backup/improve_date_updated branch from 855bc17 to cbdff26 Compare July 28, 2023 17:35
@azaslavsky azaslavsky force-pushed the azaslavsky/backup/email_obfuscator branch from 1a19d36 to 40a19fe Compare July 28, 2023 17:35
@azaslavsky azaslavsky force-pushed the azaslavsky/backup/email_obfuscator branch from 40a19fe to 20edd8c Compare July 28, 2023 17:42
@azaslavsky azaslavsky force-pushed the azaslavsky/backup/improve_date_updated branch from cbdff26 to 5c84714 Compare July 28, 2023 21:46
@azaslavsky azaslavsky force-pushed the azaslavsky/backup/email_obfuscator branch from 20edd8c to 782f35a Compare July 28, 2023 21:46
@azaslavsky azaslavsky force-pushed the azaslavsky/backup/improve_date_updated branch from 5c84714 to 3a4509d Compare July 28, 2023 23:21
@azaslavsky azaslavsky force-pushed the azaslavsky/backup/email_obfuscator branch from 782f35a to 58ae734 Compare July 28, 2023 23:28
@azaslavsky azaslavsky force-pushed the azaslavsky/backup/improve_date_updated branch from 3a4509d to e0f1dcd Compare July 29, 2023 00:10
@azaslavsky azaslavsky force-pushed the azaslavsky/backup/email_obfuscator branch from 58ae734 to eb5a5b8 Compare July 29, 2023 00:11
@azaslavsky azaslavsky force-pushed the azaslavsky/backup/improve_date_updated branch from e0f1dcd to d6bed94 Compare July 29, 2023 01:22
@azaslavsky azaslavsky force-pushed the azaslavsky/backup/email_obfuscator branch from eb5a5b8 to df68abd Compare July 29, 2023 01:22
@azaslavsky azaslavsky force-pushed the azaslavsky/backup/improve_date_updated branch from d6bed94 to 295a3bc Compare July 31, 2023 14:30
@azaslavsky azaslavsky force-pushed the azaslavsky/backup/email_obfuscator branch from df68abd to c3574da Compare July 31, 2023 14:30
Base automatically changed from azaslavsky/backup/improve_date_updated to master July 31, 2023 15:01
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #53763 (c3574da) into master (bbfe5e1) will increase coverage by 1.78%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

❗ Current head c3574da differs from pull request most recent head 2006393. Consider uploading reports for the commit 2006393 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #53763      +/-   ##
==========================================
+ Coverage   77.74%   79.52%   +1.78%     
==========================================
  Files        4969     4964       -5     
  Lines      209957   209725     -232     
  Branches    35753    35709      -44     
==========================================
+ Hits       163227   166790    +3563     
+ Misses      41595    37814    -3781     
+ Partials     5135     5121      -14     

see 356 files with indirect coverage changes

This comparator is added to prevent sensitive data like user emails from
leaking into logs, stack traces, and so on.

Issue: getsentry/team-ospo#157
@azaslavsky azaslavsky force-pushed the azaslavsky/backup/email_obfuscator branch from c3574da to 2006393 Compare July 31, 2023 22:06
@azaslavsky azaslavsky enabled auto-merge (squash) July 31, 2023 22:17
@azaslavsky azaslavsky merged commit ed99e6e into master Jul 31, 2023
@azaslavsky azaslavsky deleted the azaslavsky/backup/email_obfuscator branch July 31, 2023 22:38
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants