Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query-builder): Escape tag values more consistently #72804

Merged

Conversation

malwilley
Copy link
Member

When we don't have the field definition, we should still escape the tag value. This fixes a bug where tag values with spaces would spill out of the filter.

@malwilley malwilley requested a review from a team June 14, 2024 20:21
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.05%. Comparing base (78334b9) to head (d75f199).

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #72804       +/-   ##
===========================================
+ Coverage   55.83%   78.05%   +22.22%     
===========================================
  Files        6588     6599       +11     
  Lines      293956   294286      +330     
  Branches    50690    50741       +51     
===========================================
+ Hits       164121   229705    +65584     
+ Misses     125552    58340    -67212     
- Partials     4283     6241     +1958     
Files Coverage Δ
...pp/components/searchQueryBuilder/valueCombobox.tsx 72.81% <100.00%> (ø)

... and 2042 files with indirect coverage changes

@malwilley malwilley merged commit 9051647 into master Jun 14, 2024
43 checks passed
@malwilley malwilley deleted the malwilley/fix/search-query-builder-escape-tag-values branch June 14, 2024 20:33
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants