Skip to content

Commit

Permalink
fix(query-builder): Escape tag values more consistently (#72804)
Browse files Browse the repository at this point in the history
When we don't have the field definition, we should still escape the tag
value. This fixes a bug where tag values with spaces would spill out of
the filter.
  • Loading branch information
malwilley authored Jun 14, 2024
1 parent 78334b9 commit 9051647
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion static/app/components/searchQueryBuilder/valueCombobox.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ function getOtherSelectedValues(token: TokenResult<Token.FILTER>): string[] {
function cleanFilterValue(key: string, value: string): string {
const fieldDef = getFieldDefinition(key);
if (!fieldDef) {
return value;
return escapeTagValue(value);
}

switch (fieldDef.valueType) {
Expand Down

0 comments on commit 9051647

Please sign in to comment.