Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replay): add has_viewed to details and index #68391

Merged
merged 14 commits into from
Apr 8, 2024
Merged

feat(replay): add has_viewed to details and index #68391

merged 14 commits into from
Apr 8, 2024

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Apr 5, 2024

Relates to #64924. Splitting #67972 into smaller PRs.

@aliu39 aliu39 requested review from a team as code owners April 5, 2024 23:39
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 5, 2024
@aliu39

This comment was marked as resolved.

Sign in to view
@codecov Codecov
Copy link

codecov bot commented Apr 5, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 794 bytes ⬆️

Bundle name Size Change
sentry-webpack-bundle-array-push 26.17MB 794 bytes ⬆️

@cmanallen
Copy link
Member

cmanallen commented Apr 8, 2024 •
edited
Loading

Changes:

  • Added a replay-viewed mock.
  • Added test coverage for has_viewed attribute.
  • Added test coverage for filtering by viewed_by_id.
  • Miscellaneous alphabetical sorting.

We need to merge two Snuba PRs to get these tests passing:

@cmanallen cmanallen merged commit 2b26437 into master Apr 8, 2024
47 of 49 checks passed
@cmanallen cmanallen deleted the aliu/replay-details-has-viewed branch April 8, 2024 20:42
shellmayr pushed a commit that referenced this pull request Apr 10, 2024
@aliu39 @cmanallen @shellmayr
feat(replay): add has_viewed to details and index (#68391)
f3c7e42 
Relates to #64924. Splitting
#67972 into smaller PRs.

---------

Co-authored-by: Colton Allen <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cmanallen cmanallen cmanallen approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aliu39 @cmanallen