Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): add viewed-by endpoint + abstract kafka utils for replay events #67972

Merged
merged 67 commits into from
Apr 9, 2024

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Mar 29, 2024

Relates to #64924

Blueprint

@aliu39 aliu39 requested review from a team as code owners March 29, 2024 22:02
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 29, 2024
@aliu39 aliu39 marked this pull request as draft March 29, 2024 22:05
@aliu39 aliu39 changed the title feat(replay): add viewed-by endpoint feat(replay): add viewed-by endpoint and has_viewed field Apr 1, 2024
Copy link

codecov bot commented Apr 4, 2024

Bundle Report

Bundle size has no change ✅

jjbayer and others added 7 commits April 9, 2024 12:25
As one step towards deprecating "Legacy Reprocessing", this hides the
"Processing Issues" settings page completely if it has never been active
before.

It is still showing up for projects which have it active, or have ever
had it active.

Along with that, it will now display a deprecation notice, though I
might remove it from this PR if it is too early for that.
handle null segment_id since it's optional
stop logging payload in process_spans
some messages take over 250ms to process, add one more span to confirm
its the deserialize
Works just like the Queries and Resources panel! In fact, I had to
introduce some temporary duplication to make it work, but in a more
generic form. I'll step back and resolve the duplication in the next
week or so.

In order to fully fix this, I need to make it possible to pass a regular
plain-old `scatter` series to a chart, which is mysteriously impossible
right now, and also doesn't have proper tooltip support.

So many crimes to undo, so little time!

- Add `onHighlight` support to `DurationChart`
- Add simple debounced state hook
- Sync the sample chart and table highlight
@aliu39 aliu39 requested review from a team as code owners April 9, 2024 17:50
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 9, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@cmanallen
Copy link
Member

Sorry for the pings everyone...

@aliu39 aliu39 requested review from a team and removed request for a team April 9, 2024 18:08
@cmanallen cmanallen merged commit c5c60d1 into master Apr 9, 2024
47 of 48 checks passed
@cmanallen cmanallen deleted the aliu/viewed-replay-endpoint branch April 9, 2024 19:26
shellmayr pushed a commit that referenced this pull request Apr 10, 2024
Relates to #64924. Splitting
#67972 into smaller PRs.

---------

Co-authored-by: Colton Allen <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.