ref(notifications): remove UserNotificationSettingsDetailsEndpoint #60302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #60302 +/- ##
==========================================
- Coverage 80.87% 80.85% -0.03%
==========================================
Files 5183 5182 -1
Lines 227661 227648 -13
Branches 38308 38308
==========================================
- Hits 184131 184058 -73
- Misses 37904 37963 +59
- Partials 5626 5627 +1
|
added 2 commits
November 21, 2023 11:00
…:getsentry/sentry into ref/delete-unused-notification-endpoints
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endpoint
UserNotificationSettingsDetailsEndpointis no longer being used by either the UI or the API as shown by this query. They are also not documented so we can just remove them.Note I had a previous PR that removed
UserNotificationDetailsEndpointwhich was a mistake. We can remove some functionality from it but can't be removed just yet.