Skip to content

Commit

Permalink
ref(notifications): remove UserNotificationSettingsDetailsEndpoint (#…
Browse files Browse the repository at this point in the history
…60302)

The endpoint `UserNotificationSettingsDetailsEndpoint` is no longer
being used by either the UI or the API as shown by this
[query](https://redash.getsentry.net/dashboards/197-endpoint-usage).
They are also not documented so we can just remove them.

Note I had a previous PR that removed `UserNotificationDetailsEndpoint`
which was a mistake. We can remove some functionality from it but can't
be removed just yet.
  • Loading branch information
Stephen Cefali authored Nov 21, 2023
1 parent 420b43d commit 583b3de
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 367 deletions.
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,6 @@ module = [
"sentry.api.endpoints.user_index",
"sentry.api.endpoints.user_notification_details",
"sentry.api.endpoints.user_notification_fine_tuning",
"sentry.api.endpoints.user_notification_settings_details",
"sentry.api.endpoints.user_permission_details",
"sentry.api.endpoints.user_permissions",
"sentry.api.endpoints.user_permissions_config",
Expand Down
89 changes: 0 additions & 89 deletions src/sentry/api/endpoints/user_notification_settings_details.py

This file was deleted.

6 changes: 0 additions & 6 deletions src/sentry/api/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,6 @@
from .endpoints.user_ips import UserIPsEndpoint
from .endpoints.user_notification_details import UserNotificationDetailsEndpoint
from .endpoints.user_notification_fine_tuning import UserNotificationFineTuningEndpoint
from .endpoints.user_notification_settings_details import UserNotificationSettingsDetailsEndpoint
from .endpoints.user_notification_settings_options import UserNotificationSettingsOptionsEndpoint
from .endpoints.user_notification_settings_options_detail import (
UserNotificationSettingsOptionsDetailEndpoint,
Expand Down Expand Up @@ -870,11 +869,6 @@
UserOrganizationsEndpoint.as_view(),
name="sentry-api-0-user-organizations",
),
re_path(
r"^(?P<user_id>[^\/]+)/notification-settings/$",
UserNotificationSettingsDetailsEndpoint.as_view(),
name="sentry-api-0-user-notification-settings",
),
re_path(
r"^(?P<user_id>[^\/]+)/notifications/$",
UserNotificationDetailsEndpoint.as_view(),
Expand Down
263 changes: 0 additions & 263 deletions tests/sentry/api/endpoints/test_user_notification_settings.py

This file was deleted.

Loading

0 comments on commit 583b3de

Please sign in to comment.