feat(perf-issues): Add an option and project option to send occurrences to platform #45709
+23
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
udameli
commented
Mar 13, 2023
| @@ -618,6 +619,14 @@ def put(self, request: Request, project) -> Response: | |||
| changed_proj_settings["sentry:performance_issue_creation_rate"] = result[ | |||
| "performanceIssueCreationRate" | |||
| ] | |||
| if "performanceIssueCreationThroughPlatform" in result: | |||
There was a problem hiding this comment.
I'll be adding a UI for this in a separate front-end PR
ceorourke
approved these changes
Mar 13, 2023
wedamija
reviewed
Mar 13, 2023
| @@ -642,6 +642,9 @@ | |||
| register("performance.issues.render_blocking_assets.fcp_ratio_threshold", default=0.33) | |||
| register("performance.issues.render_blocking_assets.size_threshold", default=1000000) | |||
|
|
|||
| # System-wise option for performance issue creation through issues platform | |||
| register("performance.issues.send_to_issues_platform", default=False) | |||
There was a problem hiding this comment.
You can save yourself the trouble of creating a UI for this by adding , flags=FLAG_MODIFIABLE_BOOL to the definition. Then you can modify it here: https://sentry.io/_admin/options/
There was a problem hiding this comment.
oh this is awesome. added it here #45866
udameli
added a commit
that referenced
this pull request
Mar 23, 2023
Use system and project options set in #45709 Fixes #43975 --------- Co-authored-by: Dan Fuller <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a system-wide and per-project options that would control whether a performance problem is sent to the occurrences platform. Both options need to be booleans since the options will be checked first in
save_aggregate_performanceand then insend_occurrence_to_platformand there's no reliable way to ensure that only one function gets run.