Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf Migration: Start writing perf issues to the issue platform #43975

Closed
Tracked by #43973
wedamija opened this issue Feb 1, 2023 · 0 comments · Fixed by #45712
Closed
Tracked by #43973

Perf Migration: Start writing perf issues to the issue platform #43975

wedamija opened this issue Feb 1, 2023 · 0 comments · Fixed by #45712
Assignees

Comments

@wedamija
Copy link
Member

wedamija commented Feb 1, 2023

We'll need to start writing performance issues to the issue platform dataset. When we do this, we'll be dual writing for some period of time. Since both perf issue detection and issue platform create/update the issue and counts, we'll need to make sure that only one of these systems is actively updating counts at any one time, otherwise we'll end up double counting.

It might make sense to split up our concept of writing here: Writing the events to the issue platform dataset and creating/updating issues. We can dual write events, since perf issues currently are writing to transactions, and in issue platform will be writing to a new dataset. And we should have a switch that flips us between creating issues via transaction ingestion vs issue platform. Might make sense to make the switch per org so that we can test it in sentry and make sure the issues still look/render correctly.

We should make sure that we send the issue to the issue platform after we've written the transaction to nodestore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants