feat(devserver): Run separate transactions post process forwarder #40130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combined post process forwarder no longer works with Sentry/Snuba defaults (fully separated errors/transactions topics). Running a combined PPF caused this error in self hosted: #40120.
github-actions
bot
added
the
Scope: Backend
| "--loglevel=debug", | ||
| "--commit-batch-size=100", | ||
| "--commit-batch-timeout-ms=1000", | ||
| ], | ||
| "post-process-forwarder-transactions": [ |
There was a problem hiding this comment.
do we want to include this down below where we do the following:
if eventstream.requires_post_process_forwarder():
daemons += [_get_daemon("post-process-forwarder")]
MeredithAnya
approved these changes
Oct 17, 2022
barkbarkimashark
pushed a commit
that referenced
this pull request
Oct 18, 2022
…0130) Combined post process forwarder no longer works with Sentry/Snuba defaults (fully separated errors/transactions topics). Running a combined PPF caused this error in self hosted: #40120. In the future it may be nice to support a PPF implementation that can consume from multiple topics in order to reduce the amount of docker containers in dev / low volume environments but this is not currently possible.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined post process forwarder no longer works with Sentry/Snuba defaults (fully separated errors/transactions topics).
Running a combined PPF caused this error in self hosted: #40120.
In the future it may be nice to support a PPF implementation that can consume from multiple topics in order to reduce the amount of docker containers in dev / low volume environments but this is not currently possible.