ref: Remove the default entity from the post process forwarder #40131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer a good default (and should probably be eventually deprecated all together) since errors and transactions are now being mapped to different topics by default (which prevents this from working properly). This change forces the user to pass a value here.
github-actions
bot
added
the
Scope: Backend
volokluev
approved these changes
Oct 17, 2022
barkbarkimashark
pushed a commit
that referenced
this pull request
Oct 18, 2022
This is no longer a good default (and should probably be eventually deprecated all together) since errors and transactions are now being mapped to different topics by default in Sentry and Snuba (which prevents this from working properly). This change forces the user to pass a value here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is no longer a good default (and should probably be eventually deprecated all together) since errors and transactions are now being mapped to different topics by default in Sentry and Snuba (which prevents this from working properly). This change forces the user to pass a value here.