Chore: parallel smoketest build #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaind
force-pushed
the
chore/parallel-smoketest-build
branch
13 times, most recently
from
7daf101
to
0d41061
Compare
6 tasks
vaind
force-pushed
the
chore/parallel-smoketest-build
branch
2 times, most recently
from
b7bd935
to
41199d9
Compare
vaind
force-pushed
the
chore/parallel-smoketest-build
branch
from
41199d9
to
ff4cf86
Compare
bruno-garcia
approved these changes
Apr 29, 2022
vaind
force-pushed
the
chore/parallel-smoketest-build
branch
from
ff4cf86
to
918eb04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding webgl added a lot of build time to the main
buildjob. I'm thinking of splitting it up to separate parallel builds for android and WebGL (those two take most of the time). I originally wanted to do it in the WebGL PR, that's why this is built on top of that and has all the commits, but then I found out I need to make a few more changes to make the sample app use the extracted UPM package. In the end I decided to use the existing set of scripts already used to build integration-test app for Windows.The changes are:
smoke-test-buildmatrix job that builds for Android and WebGLscripts/unity.ps1- when a license activation fails, it will retry after a minute of wait. This change was previously discussed and becomes more important here when we have many jobs running at the same time. Would be solved by Use GHAconcurrencyto lock a single run per license used #312 but that one is blocked (unavailable on GHA).closes #617 - it doesn't make much sense to have a Gradle export anymore, with the CI looking as it does now in this PR - we're already building on a separate platform. The best we could achieve with pre-building into a grade project first is a little more concurrency of Unity instances (due to the limited number of licences on the server), because after the gradle project is prepared, the app would be built outside of Unity, so the licence wouldn't be held. The benefit looks too small to even bother with this.
#skip-changelog