Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expo-upload-sourcemaps now works on Windows #3643

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Feb 29, 2024

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

when on Windows, the execution will call "node sentry-cli..." which will behave the same as on MacOS and Linux.
The main difference is that only calling "sentry-cli ..." on a Unix system works is due to the first line on the file telling the shell to invoke the file with the Node cli.

💡 Motivation and Context

It makes the script usable on Windows.
Fixes #3613

💚 How did you test it?

Localy on a brand new project invoking the script the same way as users did, the below script shows sentry cli being invoked on a Windows device where previously it wouldn't execute it.

⬆️ Uploading dist\_expo\static\js\web\AppEntry-f904ff768b6e71e8cc866a59c8a999de1.js bundle and sourcemap...
> Found 1 file                                                             
> Found 1 file                                                             
> Analyzing 2 sources
> Analyzing completed in 0.01s
> Rewriting sources
> Rewriting completed in 0.07s
> Adding source map references
error: This version of Sentry does not support artifact bundles. A release slug is required (provide with --release)

Add --log-level=[info|debug] or export SENTRY_LOG_LEVEL=[info|debug] to see more output.
Please attach the full debug log to all bug reports.

Command failed, however, "SENTRY_ALLOW_FAILURE" variable or "allow-failure" flag was set. Exiting with 0 exit code.
✅ Uploaded bundles and sourcemaps to Sentry successfully.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

@lucas-zimerman lucas-zimerman marked this pull request as ready for review February 29, 2024 12:25
Copy link
Contributor

github-actions bot commented Feb 29, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 422.28 ms 446.02 ms 23.75 ms
Size 17.73 MiB 19.91 MiB 2.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3853f43 329.68 ms 346.32 ms 16.64 ms
e2b64fe 316.88 ms 330.23 ms 13.35 ms
1d86dd6 405.14 ms 411.06 ms 5.92 ms
9433f35 347.64 ms 356.22 ms 8.58 ms
34aba08 328.10 ms 342.84 ms 14.74 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
e5c9b8b 409.02 ms 426.66 ms 17.64 ms
acadc0f+dirty 373.24 ms 381.51 ms 8.27 ms
ad6c299 375.94 ms 382.02 ms 6.08 ms

App size

Revision Plain With Sentry Diff
3853f43 17.73 MiB 19.81 MiB 2.08 MiB
e2b64fe 17.73 MiB 19.80 MiB 2.07 MiB
1d86dd6 17.73 MiB 19.86 MiB 2.12 MiB
9433f35 17.73 MiB 19.81 MiB 2.08 MiB
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
e5c9b8b 17.73 MiB 19.83 MiB 2.10 MiB
acadc0f+dirty 17.73 MiB 19.75 MiB 2.01 MiB
ad6c299 17.73 MiB 19.75 MiB 2.02 MiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1237.71 ms 1239.04 ms 1.33 ms
Size 2.92 MiB 3.47 MiB 562.39 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
80b2ce3+dirty 1245.12 ms 1262.04 ms 16.92 ms
d7401ac+dirty 1288.10 ms 1289.54 ms 1.44 ms
e5c9b8b+dirty 1276.90 ms 1280.92 ms 4.02 ms
acadc0f+dirty 1271.12 ms 1272.28 ms 1.16 ms
728164b+dirty 1280.06 ms 1285.26 ms 5.20 ms
3ffcddd+dirty 1272.22 ms 1273.98 ms 1.76 ms
9a3ca65+dirty 1276.40 ms 1279.14 ms 2.74 ms
457e29f+dirty 1256.71 ms 1258.50 ms 1.79 ms
12427f4+dirty 1224.90 ms 1231.40 ms 6.50 ms
2534337+dirty 1220.87 ms 1221.47 ms 0.60 ms

App size

Revision Plain With Sentry Diff
80b2ce3+dirty 2.92 MiB 3.40 MiB 492.75 KiB
d7401ac+dirty 2.92 MiB 3.40 MiB 488.06 KiB
e5c9b8b+dirty 2.92 MiB 3.43 MiB 524.50 KiB
acadc0f+dirty 2.92 MiB 3.39 MiB 487.34 KiB
728164b+dirty 2.92 MiB 3.44 MiB 533.26 KiB
3ffcddd+dirty 2.92 MiB 3.40 MiB 494.39 KiB
9a3ca65+dirty 2.92 MiB 3.37 MiB 464.32 KiB
457e29f+dirty 2.92 MiB 3.43 MiB 524.75 KiB
12427f4+dirty 2.92 MiB 3.44 MiB 533.29 KiB
2534337+dirty 2.92 MiB 3.43 MiB 529.76 KiB

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you!

@krystofwoldrich krystofwoldrich merged commit 288a14d into main Feb 29, 2024
45 of 52 checks passed
@krystofwoldrich krystofwoldrich deleted the fix/expo-windows branch February 29, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants