-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expo-upload-sourcemaps now works on Windows #3643
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3853f43 | 329.68 ms | 346.32 ms | 16.64 ms |
e2b64fe | 316.88 ms | 330.23 ms | 13.35 ms |
1d86dd6 | 405.14 ms | 411.06 ms | 5.92 ms |
9433f35 | 347.64 ms | 356.22 ms | 8.58 ms |
34aba08 | 328.10 ms | 342.84 ms | 14.74 ms |
8900e1a+dirty | 430.68 ms | 456.13 ms | 25.44 ms |
e73f4ed+dirty | 332.96 ms | 354.33 ms | 21.37 ms |
e5c9b8b | 409.02 ms | 426.66 ms | 17.64 ms |
acadc0f+dirty | 373.24 ms | 381.51 ms | 8.27 ms |
ad6c299 | 375.94 ms | 382.02 ms | 6.08 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3853f43 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
e2b64fe | 17.73 MiB | 19.80 MiB | 2.07 MiB |
1d86dd6 | 17.73 MiB | 19.86 MiB | 2.12 MiB |
9433f35 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
34aba08 | 17.73 MiB | 19.80 MiB | 2.07 MiB |
8900e1a+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
e73f4ed+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
e5c9b8b | 17.73 MiB | 19.83 MiB | 2.10 MiB |
acadc0f+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
ad6c299 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
lucas-zimerman
commented
Feb 29, 2024
lucas-zimerman
commented
Feb 29, 2024
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
80b2ce3+dirty | 1245.12 ms | 1262.04 ms | 16.92 ms |
d7401ac+dirty | 1288.10 ms | 1289.54 ms | 1.44 ms |
e5c9b8b+dirty | 1276.90 ms | 1280.92 ms | 4.02 ms |
acadc0f+dirty | 1271.12 ms | 1272.28 ms | 1.16 ms |
728164b+dirty | 1280.06 ms | 1285.26 ms | 5.20 ms |
3ffcddd+dirty | 1272.22 ms | 1273.98 ms | 1.76 ms |
9a3ca65+dirty | 1276.40 ms | 1279.14 ms | 2.74 ms |
457e29f+dirty | 1256.71 ms | 1258.50 ms | 1.79 ms |
12427f4+dirty | 1224.90 ms | 1231.40 ms | 6.50 ms |
2534337+dirty | 1220.87 ms | 1221.47 ms | 0.60 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
80b2ce3+dirty | 2.92 MiB | 3.40 MiB | 492.75 KiB |
d7401ac+dirty | 2.92 MiB | 3.40 MiB | 488.06 KiB |
e5c9b8b+dirty | 2.92 MiB | 3.43 MiB | 524.50 KiB |
acadc0f+dirty | 2.92 MiB | 3.39 MiB | 487.34 KiB |
728164b+dirty | 2.92 MiB | 3.44 MiB | 533.26 KiB |
3ffcddd+dirty | 2.92 MiB | 3.40 MiB | 494.39 KiB |
9a3ca65+dirty | 2.92 MiB | 3.37 MiB | 464.32 KiB |
457e29f+dirty | 2.92 MiB | 3.43 MiB | 524.75 KiB |
12427f4+dirty | 2.92 MiB | 3.44 MiB | 533.29 KiB |
2534337+dirty | 2.92 MiB | 3.43 MiB | 529.76 KiB |
krystofwoldrich
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
when on Windows, the execution will call "node sentry-cli..." which will behave the same as on MacOS and Linux.
The main difference is that only calling "sentry-cli ..." on a Unix system works is due to the first line on the file telling the shell to invoke the file with the Node cli.
💡 Motivation and Context
It makes the script usable on Windows.
Fixes #3613
💚 How did you test it?
Localy on a brand new project invoking the script the same way as users did, the below script shows sentry cli being invoked on a Windows device where previously it wouldn't execute it.
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps