Skip to content

Commit

Permalink
fix(expo): expo-upload-sourcemaps now works on Windows (#3643)
Browse files Browse the repository at this point in the history
  • Loading branch information
lucas-zimerman authored Feb 29, 2024
1 parent f63f870 commit 288a14d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Fixes

- expo-upload-sourcemaps now works on Windows ([#3643](https://github.com/getsentry/sentry-react-native/pull/3643))
- Option `enabled: false` ensures no events are sent ([#3606](https://github.com/getsentry/sentry-react-native/pull/3606))
- Ignore JSON response when retrieving source context from local Expo Dev Server ([#3611](https://github.com/getsentry/sentry-react-native/pull/3611))

Expand Down
3 changes: 2 additions & 1 deletion scripts/expo-upload-sourcemaps.js
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,8 @@ for (const [assetGroupName, assets] of Object.entries(groupedAssets)) {
}

const isHermes = assets.find(asset => asset.endsWith('.hbc'));
execSync(`${sentryCliBin} sourcemaps upload ${isHermes ? '--debug-id-reference' : ''} ${assets.join(' ')}`, {
const windowsCallback = process.platform === "win32" ? 'node ' : '';
execSync(`${windowsCallback}${sentryCliBin} sourcemaps upload ${isHermes ? '--debug-id-reference' : ''} ${assets.join(' ')}`, {
env: {
...process.env,
[SENTRY_PROJECT]: sentryProject,
Expand Down

0 comments on commit 288a14d

Please sign in to comment.