fix: Bugfix async start / Clone Object before send over bridge

android/src/main/java/io/sentry/RNSentryModule.java

@@ -7,7 +7,6 @@
 
 import com.facebook.react.ReactApplication;
 import com.facebook.react.bridge.Arguments;
-import com.facebook.react.bridge.Callback;
 import com.facebook.react.bridge.Promise;
 import com.facebook.react.bridge.ReactApplicationContext;
 import com.facebook.react.bridge.ReactContextBaseJavaModule;
@@ -91,7 +90,7 @@ public Map<String, Object> getConstants() {
     }
 
     @ReactMethod
-    public void startWithDsnString(String dsnString, final ReadableMap options, Callback successCallback, Callback errorCallback) {
+    public void startWithDsnString(String dsnString, final ReadableMap options, Promise promise) {
         if (sentryClient != null) {
             logger.info(String.format("Already started, use existing client '%s'", dsnString));
             return;
@@ -101,7 +100,7 @@ public void startWithDsnString(String dsnString, final ReadableMap options, Call
             sentryClient = Sentry.init(dsnString, new AndroidSentryClientFactory(this.getReactApplicationContext()));
         } catch (Exception e) {
             logger.info(String.format("Catching on startWithDsnString, calling callback" + e.getMessage()));
-            errorCallback.invoke(e.getMessage());
+            promise.reject("SentryError", "Error during init", e);
             return;
         }
 
@@ -151,7 +150,7 @@ public boolean shouldSend(Event event) {
             }
         });
         logger.info(String.format("startWithDsnString '%s'", dsnString));
-        successCallback.invoke();
+        promise.resolve(true);
     }
 
     @ReactMethod

ios/RNSentry.m

@@ -125,7 +125,10 @@ - (void)setReleaseVersionDist:(SentryEvent *)event {
     resolve(crashedLastLaunch);
 }
 
-RCT_EXPORT_METHOD(startWithDsnString:(NSString * _Nonnull)dsnString options:(NSDictionary *_Nonnull)options)
+RCT_EXPORT_METHOD(startWithDsnString:(NSString * _Nonnull)dsnString
+                  options:(NSDictionary *_Nonnull)options
+                  resolve:(RCTPromiseResolveBlock)resolve
+                  rejecter:(RCTPromiseRejectBlock)reject)
 {
     NSError *error = nil;
     self.moduleMapping = [[NSMutableDictionary alloc] init];
@@ -152,7 +155,10 @@ - (void)setReleaseVersionDist:(SentryEvent *)event {
     [SentryClient.sharedClient startCrashHandlerWithError:&error];
     if (error) {
         [NSException raise:@"SentryReactNative" format:@"%@", error.localizedDescription];
+        reject(@"SentryReactNative", error.localizedDescription, error);
+        return;
     }
+    resolve(@YES);
 }
 
 RCT_EXPORT_METHOD(activateStacktraceMerging:(RCTPromiseResolveBlock)resolve

lib/NativeClient.js

@@ -56,14 +56,8 @@ export class NativeClient {
     Object.assign(this.options, options);
   }
 
-  async customInit() {
-    return new Promise((resolve, reject) => {
-      RNSentry.startWithDsnString(this._dsn, this.options, () => {
-        resolve();
-      }, (err) => {
-        reject(err);
-      });
-
+  async install() {
+    return RNSentry.startWithDsnString(this._dsn, this.options).then(() => {
       if (this.options.deactivateStacktraceMerging === false) {
         this._activateStacktraceMerging();
         const eventEmitter = new NativeEventEmitter(RNSentryEventEmitter);
@@ -77,36 +71,40 @@ export class NativeClient {
           }
         });
       }
-      RNSentry.setLogLevel(options.logLevel);
+      RNSentry.setLogLevel(this.options.logLevel);
     });
   }
 
+  _cloneObject(obj) {
+    return JSON.parse(JSON.stringify(obj));
+  }
+
   nativeCrash() {
     RNSentry.crash();
   }
 
   captureEvent(event) {
-    RNSentry.captureEvent(event);
+    RNSentry.captureEvent(this._cloneObject(event));
   }
 
   setUserContext(user) {
-    RNSentry.setUser(user);
+    RNSentry.setUser(this._cloneObject(user));
   }
 
   setTagsContext(tags) {
-    RNSentry.setTags(tags);
+    RNSentry.setTags(this._cloneObject(tags));
   }
 
   setExtraContext(extra) {
-    RNSentry.setExtra(extra);
+    RNSentry.setExtra(this._cloneObject(extra));
   }
 
   addExtraContext(key, value) {
     RNSentry.addExtra(key, value);
   }
 
   captureBreadcrumb(breadcrumb) {
-    RNSentry.captureBreadcrumb(breadcrumb);
+    RNSentry.captureBreadcrumb(this._cloneObject(breadcrumb));
   }
 
   clearContext() {

lib/Sentry.js

@@ -21,7 +21,7 @@ export const SentryLog = {
 };
 
 export const Sentry = {
-  async install() {
+  install() {
     // We have to first setup raven otherwise react-native will freeze the options
     // and some properties like ignoreErrors can not be mutated by raven-js
     Sentry._ravenClient = new RavenClient(Sentry._dsn, Sentry.options);
@@ -31,7 +31,6 @@ export const Sentry = {
       Sentry.options.disableNativeIntegration === false
     ) {
       Sentry._nativeClient = new NativeClient(Sentry._dsn, Sentry.options);
-      await Sentry._nativeClient.customInit();
       Sentry.eventEmitter = new NativeEventEmitter(RNSentryEventEmitter);
       Sentry.eventEmitter.addListener(
         RNSentryEventEmitter.EVENT_SENT_SUCCESSFULLY,
@@ -44,9 +43,20 @@ export const Sentry = {
         if (Sentry._internalEventStored) Sentry._internalEventStored();
       });
     }
-    // We need to call install here since this add the callback for sending events
-    // over the native bridge
-    Sentry._ravenClient.install();
+    if (Sentry._nativeClient) {
+      Sentry._nativeClient
+        .install()
+        .then(() => {
+          Sentry._ravenClient.install();
+        })
+        .catch(error => {
+          throw error;
+        });
+    } else {
+      // We need to call install here since this add the callback for sending events
+      // over the native bridge
+      Sentry._ravenClient.install();
+    }
   },
 
   config(dsn, options) {