fix: Bugfix async start / Clone Object before send over bridge #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
changed the title
HazAT
changed the title
mitsuhiko
approved these changes
Feb 16, 2018
cworsley4
reviewed
Feb 16, 2018
| @@ -91,7 +90,7 @@ public String getName() { | |||
| } | |||
|
|
|||
| @ReactMethod | |||
| public void startWithDsnString(String dsnString, final ReadableMap options, Callback successCallback, Callback errorCallback) { | |||
| public void startWithDsnString(String dsnString, final ReadableMap options, Promise promise) { | |||
| if (sentryClient != null) { | |||
| logger.info(String.format("Already started, use existing client '%s'", dsnString)); | |||
There was a problem hiding this comment.
@HazAT the promise should get rejected her or it will go unanswered. Perhaps that is the objective?
| Sentry._ravenClient.install(); | ||
| }) | ||
| .catch(error => { | ||
| throw error; |
There was a problem hiding this comment.
This is uncatchable here. We repro'd by throwing in the then case like so.
try {
// install will throw if we test by putting a throw in the `then` callback.
// But since it happens in the future (asynchronously) we cannot catch it.
Sentry.config("legit_dsn_url").install();
} catch (e) {
console.error(e); // I will never be called.
}Perhaps, if config() was NOT chainable (by not returning Sentry) and it did its setup (and potential error throwing) in a synchronous manner we could catch and know when we have misconfigured the client. Or perhaps, you could pass along an event we could listen for to log when it has been misconfigured.
I definitely understand the design to not have await apart of the Sentry API. Sentry, of course, shouldn't force the app to stop until sentry starts.
| @@ -77,36 +71,40 @@ export class NativeClient { | |||
| } | |||
| }); | |||
| } | |||
| RNSentry.setLogLevel(options.logLevel); | |||
| RNSentry.setLogLevel(this.options.logLevel); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the start call async more info here:
#355
I've changed it so it works for iOS and Android.
Fixes #347