Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Add circular dependencies check #3464

Merged
merged 5 commits into from
Dec 13, 2023
Merged

chore(ci): Add circular dependencies check #3464

merged 5 commits into from
Dec 13, 2023

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Dec 12, 2023 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Expo/React Native Web logs out Sentry RN SDK cyclic dependencies warning!

💡 Motivation and Context

Better experience for Expo devs.

💚 How did you test it?

ci

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@krystofwoldrich
Copy link
Member Author

Example failed run https://github.com/getsentry/sentry-react-native/actions/runs/7184490071/job/19565739621?pr=3464

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2023 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 435.08 ms 460.83 ms 25.75 ms
Size 17.73 MiB 19.84 MiB 2.11 MiB

@krystofwoldrich krystofwoldrich marked this pull request as ready for review December 12, 2023 16:55
lucas-zimerman
lucas-zimerman approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2023 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 373.04 ms 407.79 ms 34.75 ms
Size 7.15 MiB 8.11 MiB 988.82 KiB

@krystofwoldrich krystofwoldrich merged commit f6575dd into expo Dec 13, 2023
45 of 47 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-add-circular-deps-check branch December 13, 2023 11:03
@github-actions GitHub Actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1224.75 ms 1225.76 ms 1.01 ms
Size 2.36 MiB 2.88 MiB 524.38 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @lucas-zimerman