Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyclic dependencies in sentry react native #3282

Closed
5 of 10 tasks
jayshah123 opened this issue Sep 15, 2023 · 1 comment
Closed
5 of 10 tasks

Cyclic dependencies in sentry react native #3282

jayshah123 opened this issue Sep 15, 2023 · 1 comment

Comments

@jayshah123
Copy link

jayshah123 commented Sep 15, 2023

OS:

  • Windows
  • MacOS
  • Linux

Platform:

  • iOS
  • Android

SDK:

  • @sentry/react-native (>= 1.0.0)
  • react-native-sentry (<= 0.43.2)

SDK version: 5.5.0

react-native version: 0.68.2

Are you using Expo?

  • [] Yes
  • No

Are you using sentry.io or on-premise?

  • sentry.io (SaaS)
  • on-premise

If you are using sentry.io, please post a link to your issue so we can take a look:

[Link to issue]

Configuration:

(@sentry/react-native)

  Sentry.init({
    dsn: process.env.SENTRY_DSN,
    environment: 'Staging',
    release: `${appJson.version}-${appJson.jsVersion}`,
    dist: `${appJson.versionCode}`,
    beforeSend: sentryFilter,
    enableAutoPerformanceTracing: true,
    enableWatchdogTerminationTracking: false,
    tracesSampleRate: 1.0,
    integrations: [
      new Sentry.ReactNativeTracing({
        tracingOrigins: ['localhost', 'example.com', /^\//],
        routingInstrumentation,
      }),
    ],
  });

I have following issue:

App freezes on launch due to cyclic dependencies.

Steps to reproduce:

  • Install @sentry/react-native
  • Step 2

Actual result:

Require cycle: node_modules/@sentry/react-native/dist/js/measurements.js -> node_modules/@sentry/react-native/dist/js/tracing/index.js -> node_modules/@sentry/react-native/dist/js/tracing/reactnativetracing.js -> node_modules/@sentry/react-native/dist/js/measurements.js

Seeing the require cycle mentioned above.

should run fine

It should run fine

@krystofwoldrich
Copy link
Member

Hi,
thank you for the message, this message is just a warning the app should run with it.

We will remove it and add a check to prevent this in the future.
getsentry/sentry-javascript#3631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

No branches or pull requests

2 participants