Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(tracing): Add React Native Gesture Handler tracing #2865

Merged
merged 41 commits into from
Mar 21, 2023
Merged

feature(tracing): Add React Native Gesture Handler tracing #2865

merged 41 commits into from
Mar 21, 2023

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Mar 2, 2023 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

RNGH is a very popular gesture-handling library for RN. This PR adds a wrapper that makes it simple to trace the gesture interactions.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1250.82 ms 1279.08 ms 28.26 ms
Size 2.36 MiB 2.83 MiB 480.91 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9a3ca65+dirty 1247.06 ms 1274.58 ms 27.52 ms
d197b5c+dirty 1217.61 ms 1242.66 ms 25.05 ms
15c80ab+dirty 1223.74 ms 1228.96 ms 5.22 ms
52a8031+dirty 1280.88 ms 1289.78 ms 8.90 ms
e73f4ed+dirty 1243.27 ms 1244.52 ms 1.25 ms
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms
86d6d2c+dirty 1267.55 ms 1286.21 ms 18.66 ms

App size

Revision Plain With Sentry Diff
9a3ca65+dirty 2.36 MiB 2.82 MiB 462.89 KiB
d197b5c+dirty 2.36 MiB 2.82 MiB 462.86 KiB
15c80ab+dirty 2.36 MiB 2.83 MiB 474.49 KiB
52a8031+dirty 2.36 MiB 2.82 MiB 469.44 KiB
e73f4ed+dirty 2.36 MiB 2.82 MiB 469.44 KiB
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB
86d6d2c+dirty 2.36 MiB 2.82 MiB 462.82 KiB

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1301.02 ms 1308.06 ms 7.04 ms
Size 2.92 MiB 3.39 MiB 486.78 KiB

Baseline results on branch: kw-interaction-tracing

Startup times

Revision Plain With Sentry Diff
374f3bf+dirty 1264.02 ms 1275.58 ms 11.56 ms

App size

Revision Plain With Sentry Diff
374f3bf+dirty 2.92 MiB 3.38 MiB 476.29 KiB

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 292.06 ms 379.68 ms 87.62 ms
Size 7.15 MiB 8.10 MiB 977.95 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
52a8031+dirty 330.72 ms 358.76 ms 28.03 ms
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms

App size

Revision Plain With Sentry Diff
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
52a8031+dirty 7.15 MiB 8.09 MiB 965.95 KiB
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 331.54 ms 359.46 ms 27.92 ms
Size 17.73 MiB 20.06 MiB 2.32 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
52a8031+dirty 311.55 ms 321.37 ms 9.82 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms

App size

Revision Plain With Sentry Diff
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
52a8031+dirty 17.73 MiB 20.04 MiB 2.31 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB

@krystofwoldrich krystofwoldrich marked this pull request as ready for review March 6, 2023 15:04
@krystofwoldrich krystofwoldrich mentioned this pull request Mar 7, 2023
Merged
marandaneto
marandaneto reviewed Mar 9, 2023
View reviewed changes
src/js/tracing/ops.ts Outdated Show resolved Hide resolved
marandaneto
marandaneto reviewed Mar 9, 2023
View reviewed changes
src/js/tracing/ops.ts Outdated Show resolved Hide resolved
@krystofwoldrich
Copy link
Member Author

@marandaneto Can this get a final review? 🙏

marandaneto
marandaneto approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, but other than that LGTM

Base automatically changed from kw-interaction-tracing to main March 21, 2023 12:22
@krystofwoldrich krystofwoldrich changed the title Add React Native Gesture Handler tracing feature(tracing): Add React Native Gesture Handler tracing Mar 21, 2023
@krystofwoldrich krystofwoldrich merged commit e60e894 into main Mar 21, 2023
@krystofwoldrich krystofwoldrich deleted the kw-gestures-tracing branch March 21, 2023 16:16
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Add React Native Gesture Handler tracing ([#2865](https://github.com/getsentry/sentry-react-native/pull/2865))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against bcf4c68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add user interaction tracing
3 participants
@krystofwoldrich @marandaneto @web-flow