feat(sdk): UI Interaction Tracing #2835

krystofwoldrich · 2023-02-17T17:51:29Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

ReactNativeTracing has a new public method that exposes user interaction behavior. By default, it's used for touch events but can be used for any type of interaction in the future.

💡 Motivation and Context

Add user interaction tracing #2753

💚 How did you test it?

sample app, integration tests

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

waiting for: feat(tracing): Expose cancelIdleTimeout and add option to make it permanent sentry-javascript#7236
- at the moment we are using a private method to restart the idle timeout
- support cancel idle timeout when JS supports it

github-actions · 2023-02-17T17:52:41Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b15cb59

github-actions · 2023-02-17T18:15:03Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	276.51 ms	301.06 ms	24.55 ms
Size	17.73 MiB	20.05 MiB	2.32 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`9a3ca65`+dirty	326.93 ms	330.14 ms	3.21 ms
`d197b5c`+dirty	338.94 ms	354.87 ms	15.93 ms
`15c80ab`+dirty	336.27 ms	350.58 ms	14.31 ms
`52a8031`+dirty	311.55 ms	321.37 ms	9.82 ms
`e73f4ed`+dirty	332.96 ms	354.33 ms	21.37 ms
`76d1baf`+dirty	335.72 ms	355.52 ms	19.80 ms
`86d6d2c`+dirty	332.90 ms	352.45 ms	19.55 ms

App size

Revision	Plain	With Sentry	Diff
`9a3ca65`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`d197b5c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`15c80ab`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`52a8031`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`e73f4ed`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`76d1baf`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`86d6d2c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB

Previous results on branch: kw-interaction-tracing

Startup times

Revision	Plain	With Sentry	Diff
`374f3bf`+dirty	339.76 ms	351.06 ms	11.31 ms

App size

Revision	Plain	With Sentry	Diff
`374f3bf`+dirty	17.73 MiB	20.04 MiB	2.31 MiB

github-actions · 2023-02-20T12:52:52Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1267.76 ms	1286.98 ms	19.22 ms
Size	2.36 MiB	2.83 MiB	480.23 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`9a3ca65`+dirty	1247.06 ms	1274.58 ms	27.52 ms
`d197b5c`+dirty	1217.61 ms	1242.66 ms	25.05 ms
`15c80ab`+dirty	1223.74 ms	1228.96 ms	5.22 ms
`52a8031`+dirty	1280.88 ms	1289.78 ms	8.90 ms
`e73f4ed`+dirty	1243.27 ms	1244.52 ms	1.25 ms
`76d1baf`+dirty	1244.10 ms	1268.52 ms	24.42 ms
`86d6d2c`+dirty	1267.55 ms	1286.21 ms	18.66 ms

App size

Revision	Plain	With Sentry	Diff
`9a3ca65`+dirty	2.36 MiB	2.82 MiB	462.89 KiB
`d197b5c`+dirty	2.36 MiB	2.82 MiB	462.86 KiB
`15c80ab`+dirty	2.36 MiB	2.83 MiB	474.49 KiB
`52a8031`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`e73f4ed`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`76d1baf`+dirty	2.36 MiB	2.82 MiB	469.45 KiB
`86d6d2c`+dirty	2.36 MiB	2.82 MiB	462.82 KiB

Previous results on branch: kw-interaction-tracing

Startup times

Revision	Plain	With Sentry	Diff
`374f3bf`+dirty	1276.14 ms	1286.71 ms	10.57 ms

App size

Revision	Plain	With Sentry	Diff
`374f3bf`+dirty	2.36 MiB	2.82 MiB	470.08 KiB

github-actions · 2023-02-20T21:35:06Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1259.96 ms	1266.96 ms	7.00 ms
Size	2.92 MiB	3.39 MiB	487.28 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`9a3ca65`+dirty	1276.40 ms	1279.14 ms	2.74 ms
`d197b5c`+dirty	1234.80 ms	1249.20 ms	14.40 ms
`15c80ab`+dirty	1248.41 ms	1251.24 ms	2.83 ms
`52a8031`+dirty	1255.96 ms	1273.00 ms	17.04 ms
`e73f4ed`+dirty	1282.90 ms	1309.30 ms	26.40 ms
`76d1baf`+dirty	1245.00 ms	1257.76 ms	12.76 ms
`86d6d2c`+dirty	1291.62 ms	1296.80 ms	5.18 ms

App size

Revision	Plain	With Sentry	Diff
`9a3ca65`+dirty	2.92 MiB	3.37 MiB	464.32 KiB
`d197b5c`+dirty	2.92 MiB	3.37 MiB	464.41 KiB
`15c80ab`+dirty	2.92 MiB	3.39 MiB	481.56 KiB
`52a8031`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`e73f4ed`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`76d1baf`+dirty	2.92 MiB	3.38 MiB	475.74 KiB
`86d6d2c`+dirty	2.92 MiB	3.37 MiB	464.31 KiB

Previous results on branch: kw-interaction-tracing

Startup times

Revision	Plain	With Sentry	Diff
`374f3bf`+dirty	1264.02 ms	1275.58 ms	11.56 ms

App size

Revision	Plain	With Sentry	Diff
`374f3bf`+dirty	2.92 MiB	3.38 MiB	476.29 KiB

github-actions · 2023-02-20T21:59:28Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	359.21 ms	461.98 ms	102.77 ms
Size	7.15 MiB	8.09 MiB	967.12 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`76d1baf`+dirty	339.02 ms	408.65 ms	69.63 ms
`86d6d2c`+dirty	267.21 ms	325.24 ms	58.04 ms
`d197b5c`+dirty	258.75 ms	313.61 ms	54.86 ms
`9a3ca65`+dirty	344.96 ms	358.92 ms	13.96 ms
`52a8031`+dirty	330.72 ms	358.76 ms	28.03 ms

App size

Revision	Plain	With Sentry	Diff
`76d1baf`+dirty	7.15 MiB	8.09 MiB	964.41 KiB
`86d6d2c`+dirty	7.15 MiB	8.09 MiB	962.69 KiB
`d197b5c`+dirty	7.15 MiB	8.09 MiB	962.72 KiB
`9a3ca65`+dirty	7.15 MiB	8.09 MiB	962.83 KiB
`52a8031`+dirty	7.15 MiB	8.09 MiB	965.95 KiB

src/js/tracing/reactnativetracing.ts

test/touchevents.test.tsx

src/js/tracing/reactnativetracing.ts

marandaneto

Thanks @krystofwoldrich
LGTM

WIP! Add UI Tracing Element Touch Transactions

901f8c3

WIP! Add tests

32db170

Add more test and fix same event and same element behavior

46f6ce6

krystofwoldrich mentioned this pull request Feb 21, 2023

feat(tracing): Expose cancelIdleTimeout and add option to make it permanent getsentry/sentry-javascript#7236

Merged

1 task

Add different ui event and same element

eac4d01

Base automatically changed from 5.0.0 to main February 21, 2023 12:15

krystofwoldrich added 7 commits February 21, 2023 14:23

Add transactions sequence, scope and routing tests

0553f84

Fix lint

c27ba3b

Add lifecycle hooks calls to ui event transactions

e39c56c

Add JSDoc

88341e9

Merge remote-tracking branch 'origin/main' into kw-interaction-tracing

81592e4

Merge remote-tracking branch 'origin/main' into kw-interaction-tracing

ed50cf4

Add changelog

c5de70c

krystofwoldrich marked this pull request as ready for review February 28, 2023 09:49

krystofwoldrich requested a review from marandaneto as a code owner February 28, 2023 09:49

Fix lint

a4cf108

krystofwoldrich mentioned this pull request Mar 2, 2023

feature(tracing): Add React Native Gesture Handler tracing #2865

Merged

10 tasks

krystofwoldrich added 2 commits March 3, 2023 13:43

Update same event same element behavior

3025015

Merge branch 'main' into kw-interaction-tracing

170822a

marandaneto reviewed Mar 7, 2023

View reviewed changes

src/js/tracing/reactnativetracing.ts Show resolved Hide resolved

marandaneto reviewed Mar 7, 2023

View reviewed changes

test/touchevents.test.tsx Show resolved Hide resolved

marandaneto reviewed Mar 7, 2023

View reviewed changes

src/js/tracing/reactnativetracing.ts Outdated Show resolved Hide resolved

marandaneto approved these changes Mar 7, 2023

View reviewed changes

krystofwoldrich added 2 commits March 7, 2023 14:09

Merge remote-tracking branch 'origin/main' into kw-interaction-tracing

d69e641

Add cancelIdleTimeout

1495866

Update changelog

b31dcac

krystofwoldrich mentioned this pull request Mar 7, 2023

feat(rn): Add UI Instrumentation getsentry/sentry-docs#6437

Merged

krystofwoldrich added 7 commits March 9, 2023 12:03

remove duplicate ops files

63666d8

fix import

3d77eab

fix op naming

3d05093

Merge branch 'main' into kw-interaction-tracing

097c108

Update before finish callback types

915bc1a

Merge branch 'main' into kw-interaction-tracing

6191530

fix lint imports

b15cb59

krystofwoldrich merged commit 97efbbb into main Mar 21, 2023

krystofwoldrich deleted the kw-interaction-tracing branch March 21, 2023 12:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(sdk): UI Interaction Tracing #2835

feat(sdk): UI Interaction Tracing #2835

krystofwoldrich commented Feb 17, 2023 •

edited

Loading

github-actions bot commented Feb 17, 2023 •

edited

Loading

github-actions bot commented Feb 17, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-interaction-tracing

Startup times

App size

github-actions bot commented Feb 20, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-interaction-tracing

Startup times

App size

github-actions bot commented Feb 20, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-interaction-tracing

Startup times

App size

github-actions bot commented Feb 20, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

marandaneto left a comment

feat(sdk): UI Interaction Tracing #2835

feat(sdk): UI Interaction Tracing #2835

Conversation

krystofwoldrich commented Feb 17, 2023 • edited Loading

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Feb 17, 2023 • edited Loading

github-actions bot commented Feb 17, 2023 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-interaction-tracing

Startup times

App size

github-actions bot commented Feb 20, 2023 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-interaction-tracing

Startup times

App size

github-actions bot commented Feb 20, 2023 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-interaction-tracing

Startup times

App size

github-actions bot commented Feb 20, 2023 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

marandaneto left a comment

Choose a reason for hiding this comment

krystofwoldrich commented Feb 17, 2023 •

edited

Loading

github-actions bot commented Feb 17, 2023 •

edited

Loading

github-actions bot commented Feb 17, 2023 •

edited

Loading

github-actions bot commented Feb 20, 2023 •

edited

Loading

github-actions bot commented Feb 20, 2023 •

edited

Loading

github-actions bot commented Feb 20, 2023 •

edited

Loading