chore(ci): E2E RN Version Matrix #2735
Conversation
This will enable as inject the test to the different rn version project.
Android (legacy) Performance metrics 🚀
|
Android (new) Performance metrics 🚀
|
krystofwoldrich
requested review from
marandaneto and
vaind
and removed request for
marandaneto
krystofwoldrich
changed the title
| './ios/DerivedData/Build/Products/Release-iphonesimulator/sample.app', | ||
| 'appium:derivedDataPath': path.resolve('./ios/DerivedData'), | ||
| 'appium:app': process.env.APPIUM_APP, | ||
| // DerivedData of the WebDriverRunner Xcode project. |
There was a problem hiding this comment.
Don't we need this anymore?
There was a problem hiding this comment.
We do need to set the app, but now it's done by ENV so it can be dynamic. For all the apps we are testing (different paths for different RN versions.)
|
@vaind would you be willing to review this? it touches on some stuff you worked on, I guess you will have more context than me. |
There was a problem hiding this comment.
I've had a look @marandaneto but this actually doesn't change the code I've contributed here (metrics apps & CI job) so I'm not at all familiar with the changes.
gotcha, my bad then, but I guess it's a bit of the code that you refactored due to the E2E flakiness, I will review it as well, thanks. |
📢 Type of change
📜 Description
This PR builds on top of the RN Version matrix that builds RN app with the SDK for any given RN version and RN architecture.
It takes the built app and runs e2e tests against it. To do this the e2e tests are extracted from the sample app into separate npm packages that can be integrated with and run against any RN app.
💡 Motivation and Context
Closes:
💚 How did you test it?
ci, run tests locally
📝 Checklist
🔮 Next steps
#skip-changelog