-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RN 0.65.0 as a new min for SDK v5 #2687
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android (legacy) Performance metrics 🚀
|
iOS (legacy) Performance metrics 🚀
|
Android (new) Performance metrics 🚀
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
sentry-cocoa v7 and v8 has min ios version 11 and rn 0.65 is the oldest version supporting ios 11 rn 0.64 supports ios 10
krystofwoldrich
changed the title
V5 - React Native Version Matrix CI
RN 0.65.0 as a new min for SDK v5
Jan 9, 2023
9 tasks
@marandaneto Metrics are flaky. Otherwise, this is ready. |
9 tasks
marandaneto
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same cahnges just to test CI on v5
#skip-changelog
0.65.0 is the first version that supports iOS 11 and higher like our iOS SDK.
RN 0.64.0 supports iOS 10 and higher.
That's why I think we should support 0.65.0 and higher, as there should be no issue with the native deps.