-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Screenshots #2610
feat: Screenshots #2610
Conversation
|
Consider #2362 (comment) |
I know I've read it. |
…ity to screenshot processor
@krystofwoldrich is this ready for a final review os is there something missing? |
@marandaneto Ready for final review, it only waits for |
@krystofwoldrich Since you are blocked by the Java release, we can draft up the docs PR for RN, similar to https://docs.sentry.io/platforms/flutter/enriching-events/screenshots/ |
@krystofwoldrich can we unblock this? it should not be a problem cutting a patch release on Android. |
@marandaneto The release is out. So this is not blocked anymore. |
I'd way wait this getsentry/publish#1614 |
@krystofwoldrich you can unblock this -> #2653 |
📢 Type of change
📜 Description
The Screenshot feature required changes in
sentry-java
andsentry-cocoa
. Thesentry-react-native
uses the native SDKs methods to capture screenshots. Those are copied over the bridge and the envelope bytes including the screenshots are assembled on the JS/RN side and then passed back to the native layers to be sent.In case of native crashes, native SDKs capture screenshots themselves.
7.31.1
The screenshots are captured in the
client
and not in the integration due to Async/Await JS nature. In the case of multiple async integrations, the screen could be different if captured in integration.💡 Motivation and Context
Closes: #2373
Closes: #2362
💚 How did you test it?
Using sample app.
📝 Checklist
🔮 Next steps
sentry-jave
to main rebase this PR and if CI passes merge.