Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RN Screenshots #5832

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Add RN Screenshots #5832

merged 3 commits into from
Dec 5, 2022

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Nov 22, 2022

@vercel
Copy link

vercel bot commented Nov 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs ✅ Ready (Inspect) Visit Preview Dec 2, 2022 at 11:12AM (UTC)

Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the two parts about performance are separated when they should be together. I've made a suggestion, but if this doesn't work, we can figure something else out.

src/platforms/common/enriching-events/screenshots.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving it but let's release the new version before merging this.
Thanks @krystofwoldrich

@krystofwoldrich krystofwoldrich merged commit fc069c7 into master Dec 5, 2022
@krystofwoldrich krystofwoldrich deleted the rn-screenshots branch December 5, 2022 15:07
lforst pushed a commit that referenced this pull request Dec 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants